OCPBUGS-33011: fix issues with Edit Route form #13799

rhamilto · 2024-04-25T20:27:03Z

After:

Screen.Recording.2024-04-26.at.1.20.12.PM.mov

openshift-ci-robot · 2024-04-25T20:27:08Z

@rhamilto: This pull request references Jira Issue OCPBUGS-33011, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto · 2024-04-26T17:04:54Z

frontend/public/components/routes/create-route.tsx

@@ -66,7 +66,7 @@ class CreateRouteWithTranslation extends React.Component<
    namespace: getActiveNamespace(),
    labels: {},
    portOptions: {},
-    alternateServices: [],
+    alternateBackends: [],


Throughout the PR: use alternateBackends to align with the Route schema.

rhamilto · 2024-04-26T17:06:31Z

frontend/public/components/routes/create-route.tsx

-        alternateServices: updatedServiceEntriesArray,
-      };
-    });
+    this.setState(


Fixes a console error resulting from the nested setState calls. Fix is to move the second setState to a callback.

rhamilto · 2024-04-26T17:07:14Z

frontend/public/components/routes/create-route.tsx

@@ -342,7 +346,7 @@ class CreateRouteWithTranslation extends React.Component<
            className="pf-v5-c-form-control"
            type="text"
            onChange={this.handleChange}
-            value={this.state.path}
+            value={this.state.path ?? ''} // this.state.path can be set to undefined in componentDidMount


Fixes a console error related to controlled component changing to an uncontrolled one.

rhamilto · 2024-04-26T17:08:15Z

frontend/public/components/routes/create-route.tsx

@@ -426,7 +430,8 @@ class CreateRouteWithTranslation extends React.Component<
          {!_.isEmpty(portOptions) && (
            <Dropdown
              items={portOptions}
-              title={portOptions[targetPort] || t('public~Select target port')}
+              title={t('public~Select target port')}
+              selectedKey={_.isNumber(targetPort) ? UNNAMED_PORT_KEY : targetPort} // if targetPort is a number, it's an unnamed port


Fix so the Target port dropdown is correctly populated when editing (before the dropdown did not have a selected value).

rhamilto · 2024-04-26T17:09:22Z

frontend/public/components/routes/utils.ts

-  if (!_.isEmpty(alternateBackends)) {
-    route.spec.alternateBackends = alternateBackends;
-  }
+  route.spec.alternateBackends = altBackends;


This fixes the bug as reported in the Jira issue. Passing an empty array is ok!

rhamilto · 2024-04-26T17:18:54Z

frontend/public/components/routes/RoutePage.tsx

-        validationSchema={routeValidationSchema}
-        enableReinitialize
+    <>
+      <Helmet>


Add missing <title>

openshift-ci-robot · 2024-04-26T17:21:43Z

@rhamilto: This pull request references Jira Issue OCPBUGS-33011, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

After:

Screen.Recording.2024-04-26.at.1.20.12.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto · 2024-04-26T17:23:57Z

/assign @jhadvig, @TheRealJon

TheRealJon

/lgtm

openshift-ci · 2024-04-26T18:07:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [TheRealJon,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhamilto · 2024-04-26T18:27:43Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2024-04-26T18:27:46Z

@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-04-26T21:16:19Z

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-04-26T21:20:39Z

@rhamilto: Jira Issue OCPBUGS-33011: All pull requests linked via external trackers have merged:

openshift/console#13799

Jira Issue OCPBUGS-33011 has been moved to the MODIFIED state.

In response to this:

After:

Screen.Recording.2024-04-26.at.1.20.12.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2024-04-26T21:21:49Z

@rhamilto: new pull request created: #13800

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2024-04-30T05:35:28Z

Fix included in accepted release 4.16.0-0.nightly-2024-04-29-222758

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 25, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024

openshift-ci bot requested review from jcaianirh and jhadvig April 25, 2024 20:27

openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 25, 2024

rhamilto force-pushed the OCPBUGS-33011 branch from 660f2ad to d848fac Compare April 26, 2024 17:03

OCPBUGS-33011: fix issues with Edit Route form

f4803ee

rhamilto force-pushed the OCPBUGS-33011 branch from d848fac to f4803ee Compare April 26, 2024 17:18

rhamilto commented Apr 26, 2024

View reviewed changes

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 26, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 26, 2024

rhamilto changed the title ~~[WIP] OCPBUGS-33011: fix issues with Edit Route form~~ OCPBUGS-33011: fix issues with Edit Route form Apr 26, 2024

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024

TheRealJon approved these changes Apr 26, 2024

View reviewed changes

openshift-ci bot assigned TheRealJon Apr 26, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024

openshift-merge-bot bot merged commit acd4ec1 into openshift:master Apr 26, 2024
6 checks passed

openshift-cherrypick-robot mentioned this pull request Apr 26, 2024

[release-4.15] OCPBUGS-33058: fix issues with Edit Route form #13800

Open

rhamilto deleted the OCPBUGS-33011 branch April 26, 2024 22:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-33011: fix issues with Edit Route form #13799

OCPBUGS-33011: fix issues with Edit Route form #13799

rhamilto commented Apr 25, 2024 •

edited

openshift-ci-robot commented Apr 25, 2024

rhamilto Apr 26, 2024

rhamilto Apr 26, 2024

rhamilto Apr 26, 2024

rhamilto Apr 26, 2024

rhamilto Apr 26, 2024

rhamilto Apr 26, 2024

openshift-ci-robot commented Apr 26, 2024

rhamilto commented Apr 26, 2024

TheRealJon left a comment

openshift-ci bot commented Apr 26, 2024

rhamilto commented Apr 26, 2024

openshift-cherrypick-robot commented Apr 26, 2024

openshift-ci bot commented Apr 26, 2024

openshift-ci-robot commented Apr 26, 2024

openshift-cherrypick-robot commented Apr 26, 2024

openshift-merge-robot commented Apr 30, 2024

OCPBUGS-33011: fix issues with Edit Route form #13799

OCPBUGS-33011: fix issues with Edit Route form #13799

Conversation

rhamilto commented Apr 25, 2024 • edited

openshift-ci-robot commented Apr 25, 2024

rhamilto Apr 26, 2024

Choose a reason for hiding this comment

rhamilto Apr 26, 2024

Choose a reason for hiding this comment

rhamilto Apr 26, 2024

Choose a reason for hiding this comment

rhamilto Apr 26, 2024

Choose a reason for hiding this comment

rhamilto Apr 26, 2024

Choose a reason for hiding this comment

rhamilto Apr 26, 2024

Choose a reason for hiding this comment

openshift-ci-robot commented Apr 26, 2024

rhamilto commented Apr 26, 2024

TheRealJon left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Apr 26, 2024

rhamilto commented Apr 26, 2024

openshift-cherrypick-robot commented Apr 26, 2024

openshift-ci bot commented Apr 26, 2024

openshift-ci-robot commented Apr 26, 2024

openshift-cherrypick-robot commented Apr 26, 2024

openshift-merge-robot commented Apr 30, 2024

rhamilto commented Apr 25, 2024 •

edited