Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33090: UI inconsistency in topology when application grouping is collapsed #13858

Merged

Conversation

lokanandaprabhu
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/OCPBUGS-33090

Analysis / Root cause:
triggerRef was not added to the Tooltip component

Solution Description:
Added triggerRef to the Tooltip component

Screen shots / Gifs for design review:

--- Before---

Screenshot 2024-05-16 at 11 44 08 AM

---After---

Screenshot 2024-05-16 at 11 44 20 AM

Unit test coverage report:
NA

Test setup:

1. Have some deployments
2. In topology unselect the application grouping in the display filter 

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2024
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-33090, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-33090

Analysis / Root cause:
triggerRef was not added to the Tooltip component

Solution Description:
Added triggerRef to the Tooltip component

Screen shots / Gifs for design review:

--- Before---

Screenshot 2024-05-16 at 11 44 08 AM

---After---

Screenshot 2024-05-16 at 11 44 20 AM

Unit test coverage report:
NA

Test setup:

  1. Have some deployments
  2. In topology unselect the application grouping in the display filter

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 16, 2024
@openshift-ci openshift-ci bot added component/topology Related to topology approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2024
@lokanandaprabhu
Copy link
Contributor Author

/cc @jerolimov @vikram-raj @Lucifergene

@openshift-ci openshift-ci bot requested a review from jerolimov May 16, 2024 06:24
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks fine. Looks like the tooltip is not visible on hover over the name of the application. Can you please check it?

@lokanandaprabhu
Copy link
Contributor Author

@vikram-raj ,Resolved the issue. PTAL.

Copy link
Contributor

openshift-ci bot commented May 16, 2024

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Jira Issue OCPBUGS-33090, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 17, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Jira Issue OCPBUGS-33090, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lokanandaprabhu
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 20, 2024
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-33090, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9d15ca4 into openshift:master May 21, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: Jira Issue OCPBUGS-33090: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33090 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-33090

Analysis / Root cause:
triggerRef was not added to the Tooltip component

Solution Description:
Added triggerRef to the Tooltip component

Screen shots / Gifs for design review:

--- Before---

Screenshot 2024-05-16 at 11 44 08 AM

---After---

Screenshot 2024-05-16 at 11 44 20 AM

Unit test coverage report:
NA

Test setup:

  1. Have some deployments
  2. In topology unselect the application grouping in the display filter

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lokanandaprabhu
Copy link
Contributor Author

/cherrypick release-4.16 release-4.15

@lokanandaprabhu
Copy link
Contributor Author

/cherrypick release-4.16

@openshift-cherrypick-robot

@lokanandaprabhu: new pull request created: #13883

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/topology Related to topology jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants