Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tech Preview badge to odo #1501

Merged
merged 1 commit into from Apr 28, 2019
Merged

Add Tech Preview badge to odo #1501

merged 1 commit into from Apr 28, 2019

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Apr 26, 2019 •
edited by spadgett

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2019
@rhamilto
Copy link
Member Author

/retest

@spadgett
Copy link
Member

@serenamarie125 FYI

spadgett
spadgett approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

/retest

@spadgett spadgett added this to the v4.1 milestone Apr 27, 2019
@serenamarie125
Copy link
Contributor

Thanks @rhamilto @spadgett !
FYI @sspeiche

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 31babe4 into openshift:master Apr 28, 2019
@rhamilto rhamilto deleted the odo-tech-preview branch April 29, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rhamilto @spadgett @openshift-ci-robot @serenamarie125 @openshift-bot @openshift-merge-robot