Installed Operators UI updates #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated actions in kebab menu, removed filtering, and added a success icon to the non-failure status states. Fixes https://jira.coreos.com/projects/CONSOLE/issues/CONSOLE-1462
openshift-ci-robot
added
the
size/S
spadgett
requested changes
Jun 5, 2019
frontend/__tests__/components/operator-lifecycle-manager/clusterserviceversion.spec.tsx
Outdated
Show resolved
Hide resolved
frontend/public/components/operator-lifecycle-manager/clusterserviceversion.tsx
Outdated
Show resolved
Hide resolved
frontend/public/components/operator-lifecycle-manager/clusterserviceversion.tsx
Show resolved
Hide resolved
|
/cc @alecmerdler |
alecmerdler
reviewed
Jun 6, 2019
alecmerdler
reviewed
Jun 6, 2019
frontend/public/components/operator-lifecycle-manager/clusterserviceversion.tsx
Show resolved
Hide resolved
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alecmerdler, rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-aws-console-olm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the actions in kebab menu, removed filtering, and added a success icon to the "Copied" and "InstallSucceeded" status states.
I added a Jira issue for adding "Edit Subscription" and "Uninstall Operator" to the kebab menu. We're going to have to do it as a follow-on since CSVs cannot currently link to Subscriptions. Per Alec, we can only link from Subscriptions to CSVs right now.
Fixes CONSOLE-1462.
Fixes OLM-903
@openshift/team-ux-review, can you please review?