Fetch knative resources and updated sidebar resources for Overview via extension #1800

invincibleJai · 2019-06-24T06:33:00Z

Fetch knative resources and updated sidebar resources

Fetch resources for knative
Show knative routes in topology view as a decorator
Show Revisions, Routes and Configurations in side bar under resources
Update id's in order to make it unique as kind is same in case of route and service Jira #Console-1550

Jira link

https://jira.coreos.com/browse/ODC-849

Gif

Overview

Added extension to fetch resources for CRDs and handled Resource tab update across.

openshift-ci-robot · 2019-06-24T06:33:14Z

Hi @invincibleJai. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

invincibleJai · 2019-06-24T11:56:44Z

/ok-to-test

openshift-ci-robot · 2019-06-24T11:57:11Z

@invincibleJai: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christianvogt · 2019-06-24T13:14:43Z

@invincibleJai A general comment is we want to be able to contain our extensions to console in the dev console plugin. Quite possibly creating a knative plugin in the future. Often changes will be required to be able to extend an existing component in which case you should try to make the component extensible without leaking the dev console or knative domain logic into the base components.

Since the resource details component is shared and we want the revisions to show up in all instances of the overview component, we'll need a plugin extension for contributing to this component.

christianvogt · 2019-06-24T20:03:32Z

frontend/packages/dev-console/src/components/topology/TopologyDataController.tsx

@@ -91,6 +98,30 @@ const TopologyDataController: React.FC<TopologyDataControllerProps> = ({
      namespace,
      prop: 'buildconfigs',
    },
+    {
+      isList: true,
+      kind: referenceForModel(RevisionModel),


What happens to topology when knative CRDs aren't available?

What happens to topology when knative CRDs aren't available?

+1, this needs a feature flag based on the presence of the CRDs. Then we only try to watch resources that exist. Otherwise it's an error.

christianvogt · 2019-06-24T20:09:29Z

frontend/packages/dev-console/src/components/topology/topology-utils.ts

+   */
+  private getKSRoute(dc: ResourceProps): ResourceProps {
+    // get the knative route
+    const IS_KNATIVE = 'serving.knative.dev/service';


move constant to top of file

christianvogt · 2019-06-24T20:13:17Z

frontend/public/models/index.ts

@@ -889,3 +889,54 @@ export const InfrastructureModel: K8sKind = {
  crd: true,
 };

+export const RevisionModel: K8sKind = {


If we can plug into the console for knative, then these models should be defined in dev-console package.

christianvogt · 2019-06-24T20:15:28Z

frontend/public/components/overview/resource-overview-page.tsx

+        <BuildOverview buildConfigs={buildConfigs} />
+        <NetworkingOverview services={services} routes={routes} />
+      </React.Fragment>
+    ) : <KnativeOverview ksroutes={ksroutes} configurations={configurations} revisions={revisions} />}


We need to find a way to plug into the console without adding knative specific branching logic.

invincibleJai · 2019-06-25T07:13:06Z

/ok-to-test

christianvogt · 2019-06-25T15:56:01Z

@vojtechszocs does kubevirt need to extend the resource details panel?
I think we need an extension for this PR so that knative support doesn't get hard coded into these views.

fyi @spadgett

invincibleJai · 2019-06-26T17:33:45Z

/retest

christianvogt · 2019-06-26T19:04:15Z

/hold
until we look at extensibility

invincibleJai · 2019-07-16T07:21:33Z

/test e2e-aws

invincibleJai · 2019-07-16T14:08:34Z

/test e2e-aws-console-olm

invincibleJai · 2019-07-16T16:23:28Z

/test e2e-aws

invincibleJai · 2019-07-16T16:24:57Z

@christianvogt @vojtechszocs have handled review comments, pls take a look and let me know.

Thanks :)

joshuawilson · 2019-07-16T16:38:27Z

frontend/packages/console-plugin-sdk/src/typings/index.ts

@@ -9,3 +9,4 @@ export * from './nav-items';
 export * from './pages';
 export * from './perspectives';
 export * from './yaml-templates';
+export * from './overview';


please put in alphabetical order

joshuawilson · 2019-07-16T16:59:24Z

frontend/packages/dev-console/src/components/import/deployImage-submit-utils.ts

@@ -8,10 +8,10 @@ import {
 } from '@console/internal/models';
 import { k8sCreate, K8sResourceKind } from '@console/internal/module/k8s';
 import { SelectorInput } from '@console/internal/components/utils';
+import { createKnativeService } from '@console/knative-plugin/src/utils/create-knative-utils';


Why move this? It just adds one more thing to be reviewed.

had discussed with @christianvogt and IMO it would make more sense to add knative specific utils in knative-plugin as we have now

joshuawilson · 2019-07-16T18:19:37Z

/lgtm

christianvogt · 2019-07-16T18:24:51Z

/approve

openshift-bot · 2019-07-16T20:37:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

joshuawilson · 2019-07-16T23:58:25Z

/test e2e-aws

joshuawilson · 2019-07-17T03:55:09Z

/lgtm

openshift-ci-robot · 2019-07-17T03:55:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, invincibleJai, joshuawilson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

invincibleJai · 2019-07-17T04:38:37Z

/test e2e-aws-console-olm

gijohn · 2019-07-17T06:31:48Z

/test e2e-aws

gijohn · 2019-07-17T08:17:14Z

/test e2e-aws

joshuawilson · 2019-07-17T13:15:48Z

/retest

openshift-ci-robot requested a review from christianvogt June 24, 2019 06:33

openshift-ci-robot requested a review from zherman0 June 24, 2019 06:33

openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 24, 2019

spadgett added this to the v4.2 milestone Jun 24, 2019

christianvogt reviewed Jun 24, 2019

View reviewed changes

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2019

invincibleJai mentioned this pull request Jun 26, 2019

Use unique reference in redux ID #1816

Merged

invincibleJai force-pushed the fix-knative-resource-overview branch from 5f4963e to c7bb834 Compare June 26, 2019 11:50

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2019

invincibleJai force-pushed the fix-knative-resource-overview branch from c7bb834 to 77c6dd1 Compare June 26, 2019 11:58

invincibleJai force-pushed the fix-knative-resource-overview branch 2 times, most recently from e1cc4a5 to d9880c9 Compare June 26, 2019 18:13

openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 26, 2019

invincibleJai force-pushed the fix-knative-resource-overview branch from d9880c9 to bc5107e Compare July 2, 2019 03:18

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2019

invincibleJai force-pushed the fix-knative-resource-overview branch 3 times, most recently from 7e7b829 to 7dc29f6 Compare July 2, 2019 09:37

invincibleJai force-pushed the fix-knative-resource-overview branch from abd43ff to 4a3be6f Compare July 16, 2019 05:05

invincibleJai force-pushed the fix-knative-resource-overview branch from 4a3be6f to 2555afc Compare July 16, 2019 13:12

invincibleJai changed the title ~~fix(knative): fetch knative resources and updated sidebar resources~~ Fetch knative resources and updated sidebar resources for Overview via extension Jul 16, 2019

joshuawilson reviewed Jul 16, 2019

View reviewed changes

invincibleJai force-pushed the fix-knative-resource-overview branch 2 times, most recently from 826dcab to 280241c Compare July 16, 2019 17:38

openshift-ci-robot assigned joshuawilson Jul 16, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2019

fix(knative): fetch knative resources and updated sidebar resources

a4c87b5

invincibleJai force-pushed the fix-knative-resource-overview branch from 280241c to a4c87b5 Compare July 17, 2019 03:31

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2019

joshuawilson approved these changes Jul 17, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2019

openshift-merge-robot merged commit 6970d8f into openshift:master Jul 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fetch knative resources and updated sidebar resources for Overview via extension #1800

Fetch knative resources and updated sidebar resources for Overview via extension #1800

invincibleJai commented Jun 24, 2019 •

edited

openshift-ci-robot commented Jun 24, 2019

invincibleJai commented Jun 24, 2019

openshift-ci-robot commented Jun 24, 2019

christianvogt commented Jun 24, 2019

christianvogt Jun 24, 2019

spadgett Jun 25, 2019

christianvogt Jun 24, 2019

christianvogt Jun 24, 2019

christianvogt Jun 24, 2019

invincibleJai commented Jun 25, 2019

christianvogt commented Jun 25, 2019

invincibleJai commented Jun 26, 2019

christianvogt commented Jun 26, 2019

invincibleJai commented Jul 16, 2019

invincibleJai commented Jul 16, 2019

invincibleJai commented Jul 16, 2019

invincibleJai commented Jul 16, 2019

joshuawilson Jul 16, 2019

joshuawilson Jul 16, 2019

invincibleJai Jul 16, 2019

joshuawilson Jul 17, 2019

joshuawilson commented Jul 16, 2019

christianvogt commented Jul 16, 2019

openshift-bot commented Jul 16, 2019

joshuawilson commented Jul 16, 2019

joshuawilson commented Jul 17, 2019

openshift-ci-robot commented Jul 17, 2019

invincibleJai commented Jul 17, 2019

gijohn commented Jul 17, 2019

gijohn commented Jul 17, 2019

joshuawilson commented Jul 17, 2019

Fetch knative resources and updated sidebar resources for Overview via extension #1800

Fetch knative resources and updated sidebar resources for Overview via extension #1800

Conversation

invincibleJai commented Jun 24, 2019 • edited

openshift-ci-robot commented Jun 24, 2019

invincibleJai commented Jun 24, 2019

openshift-ci-robot commented Jun 24, 2019

christianvogt commented Jun 24, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

invincibleJai commented Jun 25, 2019

christianvogt commented Jun 25, 2019

invincibleJai commented Jun 26, 2019

christianvogt commented Jun 26, 2019

invincibleJai commented Jul 16, 2019

invincibleJai commented Jul 16, 2019

invincibleJai commented Jul 16, 2019

invincibleJai commented Jul 16, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshuawilson commented Jul 16, 2019

christianvogt commented Jul 16, 2019

openshift-bot commented Jul 16, 2019

joshuawilson commented Jul 16, 2019

joshuawilson commented Jul 17, 2019

openshift-ci-robot commented Jul 17, 2019

invincibleJai commented Jul 17, 2019

gijohn commented Jul 17, 2019

gijohn commented Jul 17, 2019

joshuawilson commented Jul 17, 2019

invincibleJai commented Jun 24, 2019 •

edited