New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-Check Test Files #1808
Type-Check Test Files #1808
Conversation
@vojtechszocs by excluding these dirs, we are missing type checks entirely on those files. webpack dev was the only tool in our process performing type checking. /lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
ab13ec7
to
66228f7
Compare
@christianvogt Had to fix an issue in |
Yes, it seems that |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alecmerdler, christianvogt, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Reverts https://github.com/openshift/console/pull/1708/files#diff-64282092d7b77f064e3f06a569429a99