Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-Check Test Files #1808

Merged

Conversation

alecmerdler
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2019
@alecmerdler alecmerdler requested review from christianvogt and removed request for spadgett and zherman0 June 24, 2019 18:42
@christianvogt
Copy link
Contributor

@vojtechszocs by excluding these dirs, we are missing type checks entirely on those files. webpack dev was the only tool in our process performing type checking.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2019
@alecmerdler
Copy link
Contributor Author

@christianvogt Had to fix an issue in protractor.conf.ts, ready for review again.

@vojtechszocs
Copy link
Contributor

@vojtechszocs by excluding these dirs, we are missing type checks entirely on those files. webpack dev was the only tool in our process performing type checking.

Yes, it seems that yarn dev is currently the only tool to cover that.

@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, christianvogt, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added this to the v4.2 milestone Jun 25, 2019
@openshift-merge-robot openshift-merge-robot merged commit fdeb9f7 into openshift:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants