Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CreatePVC component #2070

Merged
merged 1 commit into from Oct 17, 2019
Merged

Update CreatePVC component #2070

merged 1 commit into from Oct 17, 2019

Conversation

zherman0
Copy link
Member

@zherman0 zherman0 commented Jul 17, 2019 •
edited

Updating CreatePVC component to use functional components and hooks.

Currently WIP as I have not tested fully.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2019
@zherman0
Copy link
Member Author

/retest

@zherman0 zherman0 changed the title [WIP] Update CreatePVC component Update CreatePVC component Jul 17, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2019
@zherman0
Copy link
Member Author

/retest

@zherman0
Copy link
Member Author

/retest
/assign @spadgett

@zherman0
Copy link
Member Author

@spadgett - Can you look at this when you have some time. Thanks.

@spadgett spadgett added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 20, 2019
@spadgett spadgett added this to the v4.3 milestone Jul 20, 2019
@spadgett
Copy link
Member

/hold
Happy to see this refactor, but we'll need to target 4.3.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2019
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2019
@spadgett spadgett changed the base branch from master to master-4.3 September 17, 2019 14:18
@spadgett
Copy link
Member

/hold cancel

@zherman0 fyi, needs rebase

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2019
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin labels Sep 23, 2019
@zherman0 zherman0 force-pushed the update-pvc branch 2 times, most recently from 8d42338 to 5d7c333 Compare September 23, 2019 23:27
@zherman0 zherman0 changed the title Update CreatePVC component [WIP] Update CreatePVC component Sep 23, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2019
@zherman0
Copy link
Member Author

/retest

@spadgett
Copy link
Member

@zherman0 can you give the commit a more meaningful title? looks like the original title was lost on rebase

@spadgett spadgett removed component/ceph Related to ceph-storage-plugin component/dashboard Related to dashboard component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Oct 15, 2019
@zherman0
Copy link
Member Author

/retest

spadgett
spadgett approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2019 •
edited

@zherman0: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console e38c066 link /test e2e-aws-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c99205a into openshift:master Oct 17, 2019
@zherman0 zherman0 deleted the update-pvc branch October 17, 2019 15:01
@gnehapk
Copy link
Contributor

gnehapk commented Oct 29, 2019

@zherman0 Are you going to take these changes in 4.2 release branch as my changes -PRhttps://github.com/openshift/console/pull/2944 are based on top of this PR. Cherry picking it to 4.2 branch is giving conflicts.

@zherman0
Copy link
Member Author

zherman0 commented Oct 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zherman0 @spadgett @pweil- @openshift-ci-robot @openshift-bot @gnehapk @openshift-merge-robot