Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Serverless trigger renamed to enabled #2144

Merged
merged 1 commit into from Jul 24, 2019
Merged

fix Serverless trigger renamed to enabled #2144

merged 1 commit into from Jul 24, 2019

Conversation

invincibleJai
Copy link
Member

Serverless trigger renamed to enabled

Tracks : https://jira.coreos.com/browse/ODC-1417

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 24, 2019
@invincibleJai
Copy link
Member Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 24, 2019
@gijohn
Copy link
Contributor

gijohn commented Jul 24, 2019

Files missed:

  1. https://github.com/openshift/console/blob/master/frontend/packages/dev-console/src/components/import/advanced/AdvancedSection.tsx
  2. https://github.com/openshift/console/blob/master/frontend/packages/dev-console/src/components/import/serverless/ServerlessSection.tsx

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 24, 2019
@invincibleJai
Copy link
Member Author

@gijohn ready for review, sorry missed that

@gijohn
Copy link
Contributor

gijohn commented Jul 24, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2019
@gijohn
Copy link
Contributor

gijohn commented Jul 24, 2019

/assign @christianvogt

@gijohn gijohn removed their assignment Jul 24, 2019
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, gijohn, invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7e0b89a into openshift:master Jul 24, 2019
@spadgett spadgett added this to the v4.2 milestone Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@gijohn gijohn Awaiting requested review from gijohn

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@invincibleJai @gijohn @christianvogt @openshift-ci-robot @spadgett @openshift-merge-robot