Update Monaco editor colors #2184
Conversation
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
|
This is looking great! I'll update here when we have a new color for boolean values from Mary. I'm undecided on the white border vs. no border. It actually looks okay to me without it, but adding it would make the page more in line with the Logs and Terminal tabs. Thoughts @openshift/team-ux-review ? |
|
I wonder if we should remove the white margin around logs and terminal so there's more room for content. We take away so much space with the masthead/nav/notifications/titles/tabs I'm hesitant to add additional margins. It's really important for editors. |
|
We should look at the context menu styles as well, although I'm having trouble customizing them:
|
openshift-ci-robot
added
size/M
|
Added
|
|
/retest |
|
Color updates look great! @beanh66 talked to me about adding a margin so it's more similar to logs and terminals, and i think that would be a great suggestion. This would help the issue with the nav/editor touching. What does this look like in read only mode? |
| import { | ||
| global_BackgroundColor_100 as lineNumberActiveForeground, | ||
| global_BackgroundColor_300 as lineNumberForeground, | ||
| global_BackgroundColor_dark_100 as editorBackground, |
There was a problem hiding this comment.
Looks like this import is unused.
There was a problem hiding this comment.
@rhamilto it's used (line 39)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@spadgett agreed! Is it possible to change the color of the text in the context menu? Mary suggests either white or #EDEDED to increase contrast. |
https://jira.coreos.com/browse/CONSOLE-1621
/assign @rhamilto
cc @bmignano