fix(pipeline-service-account) copy Service account while rerunning Pipelines #2229
Conversation
openshift-ci-robot
added
size/S
|
/cc @christianvogt |
| serviceAccount: | ||
| latestRun && latestRun.spec && latestRun.spec.serviceAccount | ||
| ? latestRun.spec.serviceAccount | ||
| : pipeline && pipeline.spec && pipeline.spec.serviceAccount |
There was a problem hiding this comment.
Trying to find where in the docs it says that a pipeline has a serviceAccount property. I cannot find. Please confirm if this is correct.
There was a problem hiding this comment.
As there is no creation flow in place for Pipeline, if resources, params and serviceAccount is added to the Pipeline YAML in Spec, all the data should cascade down to every corresponding PipelineRuns when Start Pipeline/rerun Pipeline is triggered.
Is there any other option to specifically borrow these properties to pass on to the first-pipelinerun for a pipeline if not present in the Pipeline itself? @siamaksade @vdemeester @sspeiche
|
/lgtm We do not support the start scenario yet and can address the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinandan13jan, christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Addresses issue:
https://jira.coreos.com/browse/ODC-1501
POST-FIX
rerunning pipeline
pipelinerun running
pipelinerun successful
serviceAccount of pipelineRun
