Bug fix for data consumption prometheus query change #2509

afreen23 · 2019-08-28T02:56:48Z

Bug

The data consumption card searches for stale metrics and always shows No Prometheus Data Points

Fix

Updated the card with all the latest metrics

Prometheus Queries Overview

On the selection of drop down, a few metrics need to polled instead single metric per drop down
All metrics are an Instant Vector now with no values hacked into labels.
No calculation for addition/sorting needs to be done on UI front, everything is handled by queries.

Subsequent Changes in the UI

Due to the change in the Prometheus response for the current metrics , the subsequent individual functions needs to be removed.
Replaced the previous individual functions, with a switch case which then fetches the data from generic functions.
Enhancement of the chart look and feel

People

Thanx @anmolsachan for reviewing and @jeniawhite for helping with testing and providing the actual metrics for all of the cards.

Screenshots

afreen23 · 2019-08-28T02:58:15Z

@cloudbehl @rawagner @anmolsachan @jeniawhite please review

afreen23 · 2019-08-29T11:47:12Z

frontend/packages/noobaa-storage-plugin/src/constants/queries.ts

+    totalLogicalUsage: 'sum(NooBaa_providers_logical_size)',
+  },
+  [ObjectServiceDashboardQuery.PROVIDERS_BY_EGRESS]: {
+    egress: 'NooBaa_providers_bandwidth_read_size + NooBaa_providers_bandwidth_write_size',


will change this query to sorting out and all the queries to top 5 in order to be consistent with persistent dashboard

cloudbehl · 2019-08-29T11:27:19Z

...es/noobaa-storage-plugin/src/components/data-consumption-card/data-consumption-card-utils.ts

-  return [{ name: `Total Reads ${totalReads}` }, { name: `Total Writes ${totalWrites}` }];
+export const getLegendData: GetLegendData = (response, humanize) => {
+  const value = _.get(response, 'data.result[0].value[1]', null);
+  return value ? humanize(Number(value)).string : '';


No need to convert to number humanize takes care of it.

Suggested change

return value ? humanize(Number(value)).string : '';

return value ? humanize(value).string : '';

- granularized the previous metrics - extra calculations of the UI are now handled by these queries [hence optimizing the performance on UI front] Signed-off-by: Afreen Rahman <afrahman@redhat.com>

afreen23 · 2019-09-04T04:16:40Z

@cloudbehl please review it back

cloudbehl

nit: Can you change it everywhere, to differentiate between function name and the types.

afreen23 · 2019-09-04T06:56:00Z

...es/noobaa-storage-plugin/src/components/data-consumption-card/data-consumption-card-utils.ts

-  name: string;
-  unit: string;
-  yOriginal: number;
+type GetChartData = (


okay, I thought capitalizing would suffice

also its not a props type, rather a function type definition.
We can rename to GetChartDataType if its confusing.

but types are capitalized and function name are camel case, which I know the pattern in general

...es/noobaa-storage-plugin/src/components/data-consumption-card/data-consumption-card-utils.ts

+  name?: string,
+) => ChartDataPoint[];
+
+type GetDataConsumptionChartData = (


afreen23 · 2019-09-04T06:56:00Z

...es/noobaa-storage-plugin/src/components/data-consumption-card/data-consumption-card-utils.ts

-  name: string;
-  unit: string;
-  yOriginal: number;
+type GetChartData = (


okay, I thought capitalizing would suffice

- Additon of pf4 properties for bar charts - Tick values fix - Addition of top margin property in the card body Signed-off-by: Afreen Rahman <afrahman@redhat.com>

cloudbehl · 2019-09-04T08:17:16Z

/approve
/lgtm

openshift-ci-robot · 2019-09-04T08:17:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/noobaa-storage-plugin/OWNERS~~ [afreen23,cloudbehl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cloudbehl · 2019-09-04T09:07:28Z

/test e2e-aws-console

openshift-ci-robot requested review from mareklibra and rawagner August 28, 2019 02:57

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/noobaa Related to noobaa-storage-plugin labels Aug 28, 2019

afreen23 commented Aug 29, 2019

View reviewed changes

cloudbehl reviewed Aug 29, 2019

View reviewed changes

afreen23 force-pushed the data-consumption-query-change branch from c10974a to 14809ab Compare September 3, 2019 09:41

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2019

afreen23 force-pushed the data-consumption-query-change branch 2 times, most recently from e12f873 to 3362591 Compare September 3, 2019 09:46

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 3, 2019

Updated the prometheus metrics in the data consumption card

2a9f662

- granularized the previous metrics - extra calculations of the UI are now handled by these queries [hence optimizing the performance on UI front] Signed-off-by: Afreen Rahman <afrahman@redhat.com>

afreen23 force-pushed the data-consumption-query-change branch from 3362591 to 2a9f662 Compare September 3, 2019 12:22

cloudbehl reviewed Sep 4, 2019

View reviewed changes

afreen23 commented Sep 4, 2019

View reviewed changes

Enhancement of chart look and feel

7f2b524

- Additon of pf4 properties for bar charts - Tick values fix - Addition of top margin property in the card body Signed-off-by: Afreen Rahman <afrahman@redhat.com>

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2019

openshift-ci-robot assigned cloudbehl Sep 4, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019

openshift-merge-robot merged commit c6de8bf into openshift:master Sep 4, 2019

spadgett added this to the v4.2 milestone Sep 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug fix for data consumption prometheus query change #2509

Bug fix for data consumption prometheus query change #2509

afreen23 commented Aug 28, 2019 •

edited

afreen23 commented Aug 28, 2019 •

edited

afreen23 Aug 29, 2019 •

edited

cloudbehl Aug 29, 2019

afreen23 commented Sep 4, 2019

cloudbehl left a comment

afreen23 Sep 4, 2019

afreen23 Sep 4, 2019

afreen23 Sep 4, 2019

This comment was marked as outdated.

afreen23 Sep 4, 2019

cloudbehl commented Sep 4, 2019

openshift-ci-robot commented Sep 4, 2019

cloudbehl commented Sep 4, 2019

	return value ? humanize(Number(value)).string : '';
	return value ? humanize(value).string : '';

Bug fix for data consumption prometheus query change #2509

Bug fix for data consumption prometheus query change #2509

Conversation

afreen23 commented Aug 28, 2019 • edited

Bug

Fix

Prometheus Queries Overview

Subsequent Changes in the UI

People

Screenshots

afreen23 commented Aug 28, 2019 • edited

afreen23 Aug 29, 2019 • edited

Choose a reason for hiding this comment

cloudbehl Aug 29, 2019

Choose a reason for hiding this comment

afreen23 commented Sep 4, 2019

cloudbehl left a comment

Choose a reason for hiding this comment

afreen23 Sep 4, 2019

Choose a reason for hiding this comment

afreen23 Sep 4, 2019

Choose a reason for hiding this comment

afreen23 Sep 4, 2019

Choose a reason for hiding this comment

This comment was marked as outdated.

afreen23 Sep 4, 2019

Choose a reason for hiding this comment

cloudbehl commented Sep 4, 2019

openshift-ci-robot commented Sep 4, 2019

cloudbehl commented Sep 4, 2019

afreen23 commented Aug 28, 2019 •

edited

afreen23 commented Aug 28, 2019 •

edited

afreen23 Aug 29, 2019 •

edited