Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubevirt: Add edit VM flavor integration test #2517

Merged
merged 1 commit into from Oct 1, 2019
Merged

kubevirt: Add edit VM flavor integration test #2517

merged 1 commit into from Oct 1, 2019

Conversation

mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Aug 28, 2019 •
edited

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Aug 28, 2019
@mareklibra mareklibra changed the title kubevirt: Add edit VM flavor integration test WIP kubevirt: Add edit VM flavor integration test Aug 28, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2019
@mareklibra mareklibra changed the base branch from master to release-4.3 August 29, 2019 08:03
@mareklibra mareklibra changed the title WIP kubevirt: Add edit VM flavor integration test kubevirt: Add edit VM flavor integration test Aug 29, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2019
@mareklibra mareklibra changed the base branch from release-4.3 to master August 29, 2019 08:26
@mareklibra mareklibra changed the base branch from master to master-4.3 September 19, 2019 10:56
@mareklibra
Copy link
Contributor Author

Rebased as master-4.3 is created now.
Depends on #2392.

@mareklibra
Copy link
Contributor Author

mareklibra commented Sep 19, 2019 •
edited

@rhrazdil , can you please have a look? Just last 3 commits are relevant.

When rebasing, I noticed a bunch of changes in the integration tests since I wrote this PR originally and waited for the master-4.3 to be created. Aren't my changes in conflict with the intention of other PRs, please? Tests are still passing for me locally.

@mareklibra
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 23, 2019
@mareklibra
Copy link
Contributor Author

Rebased as #2392 is merged now.

rhrazdil
rhrazdil reviewed Sep 23, 2019
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/vm.detail.flavor.ts Outdated
).toBeTruthy();
});
},
VM_BOOTUP_TIMEOUT_SECS,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should come up with some more specific timeout for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: VM_CREATE_AND_EDIT_TIMEOUT_SECS, wdyt?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

rhrazdil
rhrazdil reviewed Sep 23, 2019
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/vm.wizard.configs.ts
export const CONFIG_NAME_PXE = 'PXE';
export const CONFIG_NAME_CLONED_DISK = 'ClonedDisk';

export const getProvisionConfigs = (testName: string) =>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, nice

@mareklibra mareklibra mentioned this pull request Sep 23, 2019
Merged
1 task
@mareklibra
Copy link
Contributor Author

mareklibra commented Sep 23, 2019 •
edited

I have split this PR to simplify review.

@rhrazdil
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Sep 23, 2019
@mareklibra
Copy link
Contributor Author

rebased as #2812 is merged now

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019
@mareklibra
Copy link
Contributor Author

/hold
for #2817

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

18 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2019
@mareklibra
Copy link
Contributor Author

mareklibra commented Sep 30, 2019 •
edited

linter issue fixed
@vojtechszocs , can you please have a look again? No additional change.

@mareklibra
Copy link
Contributor Author

/retest

@mareklibra
kubevirt: Add edit VM flavor integration test
c54d778 
In addition, VM Wizard integration tests are slightly refactored
for better reuse of the code.
@mareklibra
Copy link
Contributor Author

Rebased

@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, rhrazdil, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mareklibra
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 07d3e8f into openshift:master Oct 1, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhrazdil rhrazdil rhrazdil left review comments

@vojtechszocs vojtechszocs vojtechszocs requested changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@vojtechszocs vojtechszocs

@rhrazdil rhrazdil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mareklibra @rhrazdil @vojtechszocs @openshift-bot @openshift-ci-robot @spadgett @openshift-merge-robot