Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable hot reload by default #2574

Merged
merged 1 commit into from Sep 3, 2019
Merged

Enable hot reload by default #2574

merged 1 commit into from Sep 3, 2019

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Sep 3, 2019

@openshift-ci-robot
Copy link
Contributor

@spadgett: GitHub didn't allow me to request PR reviews from the following users: glekner.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @glekner @alecmerdler @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 3, 2019
alecmerdler
alecmerdler suggested changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot reloading should be allowed to be turned off. Often you can have some state you are working with in the UI, and idly making changes to the code will cause you to lose this state when the browser refreshes.

@spadgett
Copy link
Member Author

spadgett commented Sep 3, 2019

OK, I updated it to leave the logic and just flipped the default

alecmerdler
alecmerdler approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added this to the v4.2 milestone Sep 3, 2019
@openshift-merge-robot openshift-merge-robot merged commit 0c87cb9 into openshift:master Sep 3, 2019
@spadgett spadgett deleted the hot-reload branch September 3, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler alecmerdler approved these changes

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@alecmerdler alecmerdler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spadgett @openshift-ci-robot @alecmerdler @openshift-merge-robot