Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.1] Bug 1758636: Add prerelease-4.2 to channel options #2916

Merged
merged 1 commit into from Oct 4, 2019
Merged

[release-4.1] Bug 1758636: Add prerelease-4.2 to channel options #2916

merged 1 commit into from Oct 4, 2019

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Oct 4, 2019

/assign @jwforres @rhamilto
/hold

@spadgett spadgett added this to the v4.1.z milestone Oct 4, 2019
@openshift-ci-robot
Copy link
Contributor

@spadgett: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add prerelease-4.2 to channel options

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2019
@spadgett spadgett changed the title Add prerelease-4.2 to channel options [release-4.1] Add prerelease-4.2 to channel options Oct 4, 2019
@openshift-ci-robot
Copy link
Contributor

@spadgett: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.1] Add prerelease-4.2 to channel options

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett changed the title [release-4.1] Add prerelease-4.2 to channel options [release-4.1] Bug 1758636: Add prerelease-4.2 to channel options Oct 4, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 4, 2019
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1758636, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-4.1] Bug 1758636: Add prerelease-4.2 to channel options

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member Author

spadgett commented Oct 4, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2019
@jwforres
Copy link
Member

jwforres commented Oct 4, 2019

for reference this is already merged in master 4d6d3be#diff-02cfbe3474098acfb99c778fbb597ed6

@jwforres
Copy link
Member

jwforres commented Oct 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwforres, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 4, 2019
@openshift-merge-robot openshift-merge-robot merged commit 26d527e into openshift:release-4.1 Oct 4, 2019
@openshift-ci-robot
Copy link
Contributor

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1758636 has been moved to the MODIFIED state.

In response to this:

[release-4.1] Bug 1758636: Add prerelease-4.2 to channel options

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the prerelease-4.2-channel branch October 8, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@rhamilto rhamilto

@jwforres jwforres

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.1.z
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spadgett @openshift-ci-robot @jwforres @sdodson @rhamilto @openshift-merge-robot