Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement catalog source form and list page #2996

Merged
merged 1 commit into from Oct 22, 2019
Merged

Implement catalog source form and list page #2996

merged 1 commit into from Oct 22, 2019

Conversation

TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Oct 16, 2019 •
edited by spadgett

https://jira.coreos.com/browse/CONSOLE-1760

Implement new workflow for viewing and creating Catalog Sources for OperatorHub.

source list

create source

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. component/core Related to console core functionality component/olm Related to OLM labels Oct 16, 2019
@spadgett
Copy link
Member

/assign

@spadgett
Copy link
Member

/uncc @alecmerdler @jeff-phillips-18

@TheRealJon TheRealJon force-pushed the 1760-custom-catalog-source branch 2 times, most recently from be71c3b to 3c984d0 Compare October 18, 2019 17:45
spadgett
spadgett reviewed Oct 18, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this 👍 Most of my comments are about type checking

frontend/packages/operator-lifecycle-manager/src/components/catalog-source.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/catalog-source.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/catalog-source.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/catalog-source.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/catalog-source.tsx Outdated Show resolved Hide resolved
...end/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-details.tsx Outdated Show resolved Hide resolved
...end/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-details.tsx Outdated Show resolved Hide resolved
...end/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-details.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/models.ts Show resolved Hide resolved
frontend/public/components/routes/create-route.tsx Outdated Show resolved Hide resolved
@TheRealJon TheRealJon force-pushed the 1760-custom-catalog-source branch 4 times, most recently from 0bdb3ba to a091159 Compare October 22, 2019 14:36
@TheRealJon
Copy link
Member Author

@spadgett I've addressed all of your feedback.

@TheRealJon TheRealJon force-pushed the 1760-custom-catalog-source branch 2 times, most recently from 337bb78 to b84a27d Compare October 22, 2019 16:02
spadgett
spadgett approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 22, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2019
@spadgett
Copy link
Member

/kind enhancement

@openshift-ci-robot
Copy link
Contributor

@spadgett: The label(s) kind/enhancement cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga

In response to this:

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

/kind feature

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 22, 2019
@TheRealJon
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 37a8ab3 into openshift:master Oct 22, 2019
@TheRealJon TheRealJon deleted the 1760-custom-catalog-source branch October 23, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/olm Related to OLM kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TheRealJon @spadgett @openshift-ci-robot @openshift-bot @openshift-merge-robot