New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console-shared: Introduce RecentEventsBodyContent #3039
console-shared: Introduce RecentEventsBodyContent #3039
Conversation
); | ||
}; | ||
|
||
export const RecentEventsBody: React.FC<RecentEventsBodyProps> = (props) => ( | ||
<> | ||
<div className="co-activity-card__recent-title">Recent events</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about just adding showTitle
prop to original component ?
{showTitle && <div className="co-activity-card__recent-title">Recent events</div>}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my first thought as well. But do we want yet another boolean? In fact, the case here is about composition of components, so splitting these two make more sense to me.
Former `RecentEventsBody` is splitted to enable optional rendering of the title. Needed for the VM Dashboard Events card.
Rebased as #3024 is merged now. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mareklibra, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Former
RecentEventsBody
is splitted to enable optional rendering of the title.Needed for the VM Dashboard Events card.
Depends on:
Just the last commit is relevant.