Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console-shared: Introduce RecentEventsBodyContent #3039

Merged
merged 1 commit into from Oct 23, 2019
Merged

console-shared: Introduce RecentEventsBodyContent #3039

merged 1 commit into from Oct 23, 2019

Conversation

mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Oct 22, 2019

Former RecentEventsBody is splitted to enable optional rendering of the title.

Needed for the VM Dashboard Events card.

Depends on:

Just the last commit is relevant.


events

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2019
@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Oct 22, 2019
);
};

export const RecentEventsBody: React.FC<RecentEventsBodyProps> = (props) => (
<>
<div className="co-activity-card__recent-title">Recent events</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about just adding showTitle prop to original component ?

{showTitle && <div className="co-activity-card__recent-title">Recent events</div>}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my first thought as well. But do we want yet another boolean? In fact, the case here is about composition of components, so splitting these two make more sense to me.

Former `RecentEventsBody` is splitted to enable optional
rendering of the title.

Needed for the VM Dashboard Events card.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 23, 2019
@mareklibra
Copy link
Contributor Author

Rebased as #3024 is merged now.

@mareklibra mareklibra changed the title WIP console-shared: Introduce RecentEventsBodyContent console-shared: Introduce RecentEventsBodyContent Oct 23, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2019
@rawagner
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b4aea52 into openshift:master Oct 23, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants