Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP VM Network Utilization as multi-line chart #3089

Closed
wants to merge 2 commits into from
Closed

WIP VM Network Utilization as multi-line chart #3089

wants to merge 2 commits into from

Conversation

mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Oct 24, 2019

As part if this PR, the UtilizationItem is enhanced for multi-line charts.

TODO:

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Oct 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mareklibra
To complete the pull request process, please assign benjaminapetersen
You can assign the PR to them by writing /assign @benjaminapetersen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mareklibra
Copy link
Contributor Author

A simplified version of this is in #3153 to have the card landed before development freeze.

This PR will be rebased on top of the #3153 and will be focused on implementing the multi-line charts.

@mareklibra mareklibra changed the title WIP Add VM Utilization dashboard card WIP VM Network Utilization as multi-line chart Oct 30, 2019
@openshift-ci-robot
Copy link
Contributor

@mareklibra: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/frontend 1515663 link /test frontend
ci/prow/e2e-aws-console-olm 1515663 link /test e2e-aws-console-olm
ci/prow/e2e-gcp-console 1515663 link /test e2e-gcp-console
ci/prow/analyze 1515663 link /test analyze

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mareklibra
Copy link
Contributor Author

Closing in favour of #4008

@mareklibra mareklibra closed this Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

@mareklibra: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants