add PodRing to KnativeOverview Component #3266
Conversation
openshift-ci-robot
added
size/S
|
/lgtm |
| {obj.kind === RevisionModel.kind && ( | ||
| <div className="resource-overview__pod-counts"> | ||
| <PodRing | ||
| pods={current ? current.pods : []} |
There was a problem hiding this comment.
is there a possibility of current is defined but pods getting undefined. Check would help
There was a problem hiding this comment.
@invincibleJai no, If current is defined pods are going to be an empty array if no pods are available
|
@sahil143 have verified changes locally, works as expected. Have added one comment take a look. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| const isKnative = _.get(obj, 'metadata.ownerReferences[0].kind') === 'Revision'; | ||
| const isScalingAllowed = !isKnative && editable && enableScaling; | ||
| const isKnativeRevision = obj.kind === 'Revision'; | ||
| const isScalingAllowed = !isKnativeRevision && editable && enableScaling; |
There was a problem hiding this comment.
This needs a tech debt item to avoid bringing in knativeisms into the shared code. I'm not sure how else to solve this right now though.
We probably need to create some extensions.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ODC-bug: https://jira.coreos.com/browse/ODC-2165
