Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1769915: Fix bare metal backed node secondary status #3290

Merged
merged 1 commit into from Nov 9, 2019
Merged

Bug 1769915: Fix bare metal backed node secondary status #3290

merged 1 commit into from Nov 9, 2019

Conversation

jtomasek
Copy link

@jtomasek jtomasek commented Nov 7, 2019

  • Don't show host power status in Node's secondary status until host
    is properly linked to it through the associated machine

Fix bare metal backed node secondary status
5718c0a 
* Don't show host power status in Node's secondary status until host
  is properly linked to it through the associated machine
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 7, 2019
@openshift-ci-robot
Copy link
Contributor

@jtomasek: This pull request references Bugzilla bug 1769915, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1769915: Fix bare metal backed node secondary status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/metal3 Related to metal3-plugin labels Nov 7, 2019
@jtomasek
Copy link
Author

jtomasek commented Nov 7, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 7, 2019
@openshift-ci-robot
Copy link
Contributor

@jtomasek: This pull request references Bugzilla bug 1769915, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jtomasek
Copy link
Author

jtomasek commented Nov 7, 2019

/test e2e-gcp-console

1 similar comment
@jtomasek
Copy link
Author

jtomasek commented Nov 7, 2019

/test e2e-gcp-console

@honza
Copy link
Member

honza commented Nov 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@knowncitizen
Copy link
Contributor

Thought I already hit this one.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, jtomasek, knowncitizen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@honza
Copy link
Member

honza commented Nov 7, 2019

/test e2e-gcp-console

6 similar comments
@jtomasek
Copy link
Author

jtomasek commented Nov 8, 2019

/test e2e-gcp-console

@jtomasek
Copy link
Author

jtomasek commented Nov 8, 2019

/test e2e-gcp-console

@honza
Copy link
Member

honza commented Nov 8, 2019

/test e2e-gcp-console

@honza
Copy link
Member

honza commented Nov 8, 2019

/test e2e-gcp-console

@honza
Copy link
Member

honza commented Nov 8, 2019

/test e2e-gcp-console

@honza
Copy link
Member

honza commented Nov 9, 2019

/test e2e-gcp-console

@spadgett spadgett added this to the v4.3 milestone Nov 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit 958ba86 into openshift:master Nov 9, 2019
@openshift-ci-robot
Copy link
Contributor

@jtomasek: All pull requests linked via external trackers have merged. Bugzilla bug 1769915 has been moved to the MODIFIED state.

In response to this:

Bug 1769915: Fix bare metal backed node secondary status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jtomasek jtomasek deleted the node-secondary-status-fix branch December 4, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honza honza Awaiting requested review from honza

@knowncitizen knowncitizen Awaiting requested review from knowncitizen

Assignees

@knowncitizen knowncitizen

@honza honza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/metal3 Related to metal3-plugin lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jtomasek @openshift-ci-robot @honza @knowncitizen @spadgett @openshift-merge-robot