regrouping is intermittently failing on hover #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
|
/retest |
jeff-phillips-18
approved these changes
Nov 8, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test e2e-gcp-console |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-gcp-console |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://jira.coreos.com/browse/ODC-2198
The library we use for svg path hit testing,
point-in-svg-path, seems to have an issue with decimal numbers. Hit testing seemed to fail even when the coordinates clearly lay within the path. Moving the mouse one pixel over results in a pass, then one more pixel results in a fail.Rounding the hit test coordinates seems to fix the issue.
Tested at various zoom levels and pan transforms.
/assign @jeff-phillips-18