Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: increase timeout for OperatorHub subscription form #3360

Merged

Conversation

spadgett
Copy link
Member

Increase the timeout in an effort to address the following flakes. I suspect this is happening because icons might still be loading in the background, which makes the form slow to load (even with lazy icon loading).

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_console/3338/pull-ci-openshift-console-master-e2e-gcp-console/2822

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_console/3356/pull-ci-openshift-console-master-e2e-gcp-console/2823

/kind test-flake
/assign @rhamilto

@openshift-ci-robot openshift-ci-robot added kind/test-flake Categorizes issue or PR as related to test flakes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM labels Nov 12, 2019
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@spadgett
Copy link
Member Author

Previous failure was https://bugzilla.redhat.com/show_bug.cgi?id=1765280

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@spadgett
Copy link
Member Author

I pushed an additional change for the last test failure:

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_console/3360/pull-ci-openshift-console-master-e2e-gcp-console/2887

NoSuchElementError: No element found using locator: By(css selector, input[data-test=providerType-custom])

Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cf26dbc into openshift:master Nov 12, 2019
@spadgett spadgett deleted the subscription-form-timeout branch November 12, 2019 23:12
@spadgett
Copy link
Member Author

It looks like the timeout is either happening for checkLogs or checkErrors in afterEach, not waiting for the subscribe button, so the timeout increase here hasn't addressed the flake.

@spadgett spadgett added this to the v4.3 milestone Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM kind/test-flake Categorizes issue or PR as related to test flakes. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants