Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch ClusterTask without namespace if taskRef is ClusterTask #3367

Merged
merged 1 commit into from Nov 13, 2019
Merged

Fetch ClusterTask without namespace if taskRef is ClusterTask #3367

merged 1 commit into from Nov 13, 2019

Conversation

rohitkrai03
Copy link
Contributor

Related Bug - https://jira.coreos.com/browse/ODC-2245

This PR -

  • Updates PipelineVisualizationTask component to fetch ClusterTask if taskRef has a kind: ClusterTask.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console labels Nov 12, 2019
@rohitkrai03
Copy link
Contributor Author

/retest

@spadgett
Copy link
Member

could not copy stable imagestreamtag: Timeout: request did not complete within allowed duration

/retest

@rohitkrai03
Copy link
Contributor Author

/assign @karthikjeeyar

@rohitkrai03
Copy link
Contributor Author

/test e2e-gcp-console

gijohn
gijohn reviewed Nov 13, 2019
View reviewed changes
frontend/packages/dev-console/src/components/pipelines/PipelineVisualizationTask.tsx Outdated
) {
taskStatus.reason = runStatus.Cancelled;
}
}
let resources;
if (task.taskRef.kind === 'ClusterTask') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (task.taskRef.kind === 'ClusterTask') {
if (task.taskRef.kind === ClusterTaskModel.kind) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@gijohn
Copy link
Contributor

gijohn commented Nov 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gijohn, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohitkrai03
Copy link
Contributor Author

/test e2e-gcp-console

1 similar comment
@rohitkrai03
Copy link
Contributor Author

/test e2e-gcp-console

@openshift-merge-robot openshift-merge-robot merged commit 5914ed4 into openshift:master Nov 13, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 18, 2019
@rohitkrai03 rohitkrai03 deleted the bug-odc-2245 branch March 30, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gijohn gijohn gijohn left review comments

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@debsmita1 debsmita1 Awaiting requested review from debsmita1

Assignees

@karthikjeeyar karthikjeeyar

@gijohn gijohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rohitkrai03 @spadgett @gijohn @openshift-ci-robot @karthikjeeyar @openshift-merge-robot