Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1775765: Addition of skeleton components for dashboard views #3499

Merged
merged 1 commit into from Dec 6, 2019
Merged

Bug 1775765: Addition of skeleton components for dashboard views #3499

merged 1 commit into from Dec 6, 2019

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Nov 20, 2019 •
edited by spadgett

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared labels Nov 20, 2019
@spadgett
Copy link
Member

/cc @rhamilto @rawagner @andybraren

@spadgett spadgett added this to the v4.3 milestone Nov 20, 2019
rhamilto
rhamilto reviewed Nov 20, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alpha nits

frontend/packages/console-shared/src/components/dashboard/status-card/status-card.scss Outdated Show resolved Hide resolved
frontend/packages/console-shared/src/styles/skeleton-screen.scss Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
@spadgett spadgett modified the milestones: v4.3, v4.4 Nov 22, 2019
@spadgett spadgett changed the title [WIP] Addition of skeleton components for dashboard views [WIP] Bug 1775765: Addition of skeleton components for dashboard views Nov 22, 2019
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Bugzilla bug 1775765, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[WIP] Bug 1775765: Addition of skeleton components for dashboard views

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 22, 2019
TheRealJon
TheRealJon reviewed Dec 2, 2019
View reviewed changes
frontend/packages/console-shared/src/components/dashboard/status-card/status-card.scss
content: "";
display: block;
content:"";
display:block;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space after ":"

TheRealJon
TheRealJon approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2019
@sg00dwin
Copy link
Member Author

sg00dwin commented Dec 4, 2019

/retest

@sg00dwin sg00dwin force-pushed the dashboard-skeleton branch 2 times, most recently from c88838b to 6beabd7 Compare December 5, 2019 03:07
@spadgett
Copy link
Member

spadgett commented Dec 5, 2019

/retest

spadgett
spadgett approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@spadgett
Copy link
Member

spadgett commented Dec 5, 2019

@sg00dwin feel free to remove WIP if this is ready

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, sg00dwin, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sg00dwin sg00dwin changed the title [WIP] Bug 1775765: Addition of skeleton components for dashboard views Bug 1775765: Addition of skeleton components for dashboard views Dec 5, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 345effe into openshift:master Dec 6, 2019
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: All pull requests linked via external trackers have merged. Bugzilla bug 1775765 has been moved to the MODIFIED state.

In response to this:

Bug 1775765: Addition of skeleton components for dashboard views

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

spadgett commented Dec 6, 2019

/cherrypick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 6, 2019
Merged
@openshift-cherrypick-robot
Copy link

@spadgett: new pull request created: #3706

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sg00dwin sg00dwin deleted the dashboard-skeleton branch December 9, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@spadgett spadgett spadgett approved these changes

@rawagner rawagner rawagner approved these changes

@TheRealJon TheRealJon TheRealJon approved these changes

@andybraren andybraren Awaiting requested review from andybraren

Assignees

@spadgett spadgett

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@sg00dwin @spadgett @openshift-ci-robot @openshift-bot @openshift-cherrypick-robot @rhamilto @rawagner @TheRealJon @openshift-merge-robot