Bug 1777258: Changed how backingstore is spelled through out the console #3513

bipuladh · 2019-11-21T11:06:16Z

Changed how a backing store is spelled in the console.

cloudbehl

I think these should also be capitalized.

cloudbehl · 2019-11-25T06:04:07Z

...ackages/noobaa-storage-plugin/src/components/bucket-class/wizard-pages/backingstore-page.tsx

@@ -181,14 +181,14 @@ const BackingStorePage: React.FC<BackingStorePageProps> = React.memo(
        <Form className="nb-bc-step-page-form">
          <Title headingLevel="h3" size="xl" className="nb-bc-step-page-form__title">
            <Flex breakpointMods={[{ modifier: 'justify-content-space-between' }] as any}>
-              <FlexItem>Tier 1 - backingStore ({state.tier1Policy})</FlexItem>
+              <FlexItem>Tier 1 - backing Store ({state.tier1Policy})</FlexItem>


Suggested change

<FlexItem>Tier 1 - backing Store ({state.tier1Policy})</FlexItem>

<FlexItem>Tier 1 - Backing Store ({state.tier1Policy})</FlexItem>

Yes, the labels should start with a capital letter, the same as other entities in the console (such as Storage Class).

cloudbehl · 2019-11-25T06:04:26Z

...ackages/noobaa-storage-plugin/src/components/bucket-class/wizard-pages/backingstore-page.tsx

@@ -229,7 +229,7 @@ const BackingStorePage: React.FC<BackingStorePageProps> = React.memo(
        {showTier2Table && (
          <Form className="nb-bc-step-page-form">
            <Title headingLevel="h3" size="xl">
-              Tier 2 - backingStore ({state.tier2Policy}){' '}
+              Tier 2 - backing Store ({state.tier2Policy}){' '}


Suggested change

Tier 2 - backing Store ({state.tier2Policy}){' '}

Tier 2 - Backing Store ({state.tier2Policy}){' '}

cloudbehl · 2019-11-25T08:27:54Z

/kind bug

cloudbehl · 2019-11-25T08:28:21Z

/approve
/assign @shirimordechay

bipuladh · 2019-11-26T05:45:35Z

/test e2e-gcp-console

bipuladh · 2019-11-27T04:29:13Z

/retest

bipuladh · 2019-11-27T05:54:31Z

/retest

openshift-ci-robot · 2019-11-27T10:02:46Z

@bipuladh: This pull request references Bugzilla bug 1777258, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1777258: Changed how backingstore is spelled through out the console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-11-27T10:12:19Z

@bipuladh: This pull request references Bugzilla bug 1777258, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2019-11-27T10:13:22Z

/bugzilla refresh

openshift-ci-robot · 2019-11-27T10:13:30Z

@bipuladh: This pull request references Bugzilla bug 1777258, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2019-11-27T10:13:37Z

/retest

bipuladh · 2019-11-27T11:24:28Z

/retest

…fixes

cloudbehl · 2019-11-27T13:53:49Z

/test e2e-gcp-console
/lgtm

openshift-ci-robot · 2019-11-27T13:54:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/noobaa-storage-plugin/OWNERS~~ [bipuladh,cloudbehl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2019-11-27T14:03:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

bipuladh · 2019-11-27T15:17:31Z

/retest

openshift-bot · 2019-11-27T15:21:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-11-27T17:11:51Z

@bipuladh: All pull requests linked via external trackers have merged. Bugzilla bug 1777258 has been moved to the MODIFIED state.

In response to this:

Bug 1777258: Changed how backingstore is spelled through out the console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2019-11-27T18:42:10Z

@bipuladh: #3513 failed to apply on top of branch "release-4.3":

Using index info to reconstruct a base tree...
M	frontend/packages/noobaa-storage-plugin/src/components/bucket-class/create-bc.tsx
M	frontend/packages/noobaa-storage-plugin/src/components/bucket-class/wizard-pages/review-page.tsx
M	frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs-page.tsx
M	frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs.tsx
Auto-merging frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs-page.tsx
CONFLICT (content): Merge conflict in frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs-page.tsx
Auto-merging frontend/packages/noobaa-storage-plugin/src/components/bucket-class/wizard-pages/review-page.tsx
Auto-merging frontend/packages/noobaa-storage-plugin/src/components/bucket-class/create-bc.tsx
error: Failed to merge in the changes.
Patch failed at 0001 Changed how backingstore is spelled through out the console and typo fixes

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2019-12-05T05:50:34Z

/cherrypick release-4.3

openshift-cherrypick-robot · 2019-12-05T05:50:38Z

@bipuladh: #3513 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	frontend/packages/noobaa-storage-plugin/src/components/bucket-class/create-bc.tsx
M	frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs-page.tsx
M	frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs.tsx
Auto-merging frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs-page.tsx
CONFLICT (content): Merge conflict in frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs-page.tsx
Auto-merging frontend/packages/noobaa-storage-plugin/src/components/bucket-class/create-bc.tsx
Patch failed at 0001 Changed how backingstore is spelled through out the console and typo fixes

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2019-12-09T07:29:43Z

/cherrypick release-4.3

openshift-cherrypick-robot · 2019-12-09T07:29:47Z

@bipuladh: #3513 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	frontend/packages/noobaa-storage-plugin/src/components/bucket-class/create-bc.tsx
M	frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs-page.tsx
M	frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs.tsx
Auto-merging frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs-page.tsx
CONFLICT (content): Merge conflict in frontend/packages/noobaa-storage-plugin/src/components/create-backingstore-page/create-bs-page.tsx
Auto-merging frontend/packages/noobaa-storage-plugin/src/components/bucket-class/create-bc.tsx
Patch failed at 0001 Changed how backingstore is spelled through out the console and typo fixes

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added component/noobaa Related to noobaa-storage-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2019

openshift-ci-robot requested review from gnehapk and rawagner November 21, 2019 11:06

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019

cloudbehl reviewed Nov 25, 2019

View reviewed changes

bipuladh force-pushed the typo-fixes branch from 979f5fd to c1fafc2 Compare November 25, 2019 08:24

bipuladh requested a review from cloudbehl November 25, 2019 08:26

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 25, 2019

openshift-ci-robot assigned shirimordechay Nov 25, 2019

bipuladh changed the title ~~Changed how backingstore is spelled through out the console~~ Bug 1777258: Changed how backingstore is spelled through out the console Nov 27, 2019

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 27, 2019

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 27, 2019

bipuladh force-pushed the typo-fixes branch from c1fafc2 to 135315a Compare November 27, 2019 11:46

Changed how backingstore is spelled through out the console and typo …

cf274b1

…fixes

bipuladh force-pushed the typo-fixes branch from 135315a to cf274b1 Compare November 27, 2019 12:00

openshift-ci-robot assigned cloudbehl Nov 27, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019

openshift-merge-robot merged commit c868960 into openshift:master Nov 27, 2019

bipuladh mentioned this pull request Dec 9, 2019

[release-4.3] Bug 1781051: Fixes backingstore spelling throughout the console #3722

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1777258: Changed how backingstore is spelled through out the console #3513

Bug 1777258: Changed how backingstore is spelled through out the console #3513

bipuladh commented Nov 21, 2019

cloudbehl left a comment

cloudbehl Nov 25, 2019

shirimordechay Nov 25, 2019

cloudbehl Nov 25, 2019

cloudbehl commented Nov 25, 2019

cloudbehl commented Nov 25, 2019

bipuladh commented Nov 26, 2019

bipuladh commented Nov 27, 2019

bipuladh commented Nov 27, 2019

openshift-ci-robot commented Nov 27, 2019

openshift-ci-robot commented Nov 27, 2019

bipuladh commented Nov 27, 2019

openshift-ci-robot commented Nov 27, 2019

bipuladh commented Nov 27, 2019

bipuladh commented Nov 27, 2019

cloudbehl commented Nov 27, 2019

openshift-ci-robot commented Nov 27, 2019

openshift-bot commented Nov 27, 2019

bipuladh commented Nov 27, 2019

openshift-bot commented Nov 27, 2019

openshift-ci-robot commented Nov 27, 2019

openshift-cherrypick-robot commented Nov 27, 2019

bipuladh commented Dec 5, 2019

openshift-cherrypick-robot commented Dec 5, 2019

bipuladh commented Dec 9, 2019

openshift-cherrypick-robot commented Dec 9, 2019

	<FlexItem>Tier 1 - backing Store ({state.tier1Policy})</FlexItem>
	<FlexItem>Tier 1 - Backing Store ({state.tier1Policy})</FlexItem>

	Tier 2 - backing Store ({state.tier2Policy}){' '}
	Tier 2 - Backing Store ({state.tier2Policy}){' '}

Bug 1777258: Changed how backingstore is spelled through out the console #3513

Bug 1777258: Changed how backingstore is spelled through out the console #3513

Conversation

bipuladh commented Nov 21, 2019

cloudbehl left a comment

Choose a reason for hiding this comment

cloudbehl Nov 25, 2019

Choose a reason for hiding this comment

shirimordechay Nov 25, 2019

Choose a reason for hiding this comment

cloudbehl Nov 25, 2019

Choose a reason for hiding this comment

cloudbehl commented Nov 25, 2019

cloudbehl commented Nov 25, 2019

bipuladh commented Nov 26, 2019

bipuladh commented Nov 27, 2019

bipuladh commented Nov 27, 2019

openshift-ci-robot commented Nov 27, 2019

openshift-ci-robot commented Nov 27, 2019

bipuladh commented Nov 27, 2019

openshift-ci-robot commented Nov 27, 2019

bipuladh commented Nov 27, 2019

bipuladh commented Nov 27, 2019

cloudbehl commented Nov 27, 2019

openshift-ci-robot commented Nov 27, 2019

openshift-bot commented Nov 27, 2019

bipuladh commented Nov 27, 2019

openshift-bot commented Nov 27, 2019

openshift-ci-robot commented Nov 27, 2019

openshift-cherrypick-robot commented Nov 27, 2019

bipuladh commented Dec 5, 2019

openshift-cherrypick-robot commented Dec 5, 2019

bipuladh commented Dec 9, 2019

openshift-cherrypick-robot commented Dec 9, 2019