Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bug 1769317: Mark all resources as optional to always render card by firehose" #3549

Merged
merged 1 commit into from Nov 23, 2019
Merged

Revert "Bug 1769317: Mark all resources as optional to always render card by firehose" #3549

merged 1 commit into from Nov 23, 2019

Conversation

spadgett
Copy link
Member

Reverts #3374

See #3547 (comment). Reverting for now.

/assign @rhamilto
/cc @rawagner

@spadgett spadgett added this to the v4.4 milestone Nov 22, 2019
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1769317, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Revert "Bug 1769317: Mark all resources as optional to always render card by firehose"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. component/core Related to console core functionality component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 22, 2019
rhamilto
rhamilto approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7bc0cee into master Nov 23, 2019
@openshift-ci-robot
Copy link
Contributor

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1769317 has been moved to the MODIFIED state.

In response to this:

Revert "Bug 1769317: Mark all resources as optional to always render card by firehose"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the revert-3374-fix_missing_model_loop branch November 23, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dashboard Related to dashboard lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spadgett @openshift-ci-robot @rhamilto @openshift-merge-robot