Added tests for object service dashboard page #3555

bipuladh · 2019-11-24T20:15:18Z

Integration for Object Service Dashboard
Todo:

Add "id" for better for CSS selection.

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.ts

umangachapagain · 2019-11-25T05:54:56Z

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.ts

+    let text = await obcCount.getText();
+    const initialCount = text.substring(0, 1);
+    // Go to create form page
+    await browser.get(


Aren't we supposed to click on "Create OBC" button and expect to be redirected to this link, instead of just redirecting to the URL?

Yes but will be following a different approach, will use kubectl to create obc.

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.ts

umangachapagain · 2019-11-25T06:02:59Z

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.ts

+
+  it('Checks whether MCG is healthy', async () => {
+    await browser.get(`${appHost}/dashboards/object-service`);
+    expect(clusterHealth.isPresent()).toBeFalsy();


Why are we expecting it to be false?

because there is no message for healthy status only for unhealthy and error states.

Please add a comment to the code.

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.ts

gnehapk · 2019-11-26T05:23:18Z

It seems that you have added tests for all cards here. Its better to have separate describe block for each card as looking at this PR, its not easy to identify test for each card. @bipuladh

umangachapagain

I believe we also need to add Snapshot tests (RFE) to ensure that the Pages load in the structure we expect it to have.

Otherwise, selection like below might break without any traces

export const obcCount = $(
  '#content-scrollable > div:nth-child(2) > div > div > div > div > div:nth-child(1) > div > div:nth-child(3) > article > div.pf-c-card__body.co-dashboard-card__body > div:nth-child(2) > div.nb-buckets-card__row-title > div:nth-child(1)',
);

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.scenario.ts

umangachapagain · 2019-11-26T06:21:57Z

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.scenario.ts

+  beforeAll(async () => {
+    await browser.get(`${appHost}/dashboards/object-service`);
+  });
+  it('Creates an Object Bucket Claim and test equality', async () => {


Suggested change

it('Creates an Object Bucket Claim and test equality', async () => {

it('Creates an Object Bucket Claim and tests equality', async () => {

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.scenario.ts

umangachapagain · 2019-11-26T06:29:09Z

Run linter to ensure uniform formatting.

bipuladh · 2019-11-26T07:09:54Z

@umangachapagain this code has been linted. Hence the frontend tests are passing.

umangachapagain · 2019-11-26T07:27:33Z

@umangachapagain this code has been linted. Hence the frontend tests are passing.

But there are some inconsistent new line issues between line 25 and 26, and 28 and 29.

bipuladh · 2019-11-26T09:40:38Z

/assign @rhrazdil

umangachapagain

Changes to the component itself should not be a part of this PR. Or, atleast should be in a separate commit with a little explanation on why it was done. (purely based on the processes that I have seen)

bipuladh · 2019-11-26T10:29:26Z

@umangachapagain agreed. IMO these changes will make more sense when they are accompanied by the use case. And the owners of those particular components might be able to give a better approach(possibly using a different tag). These changes aren't structural changes but are only the addition of identifier tags which would not change the layout/behaviour of these components and would not make sense to add without any pretext to add them.

rhrazdil

Suggested a few changes

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.scenario.ts

rhrazdil · 2019-11-26T10:38:46Z

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.scenario.ts

+    let text = await obcCount.getText();
+    const initialCount = text.substring(0, 1);
+    await execSync(`echo '${JSON.stringify(testBucket)}' | kubectl create -n ${testName} -f -`);
+    await browser.sleep(10000);


It would be much nicer to wait for some condition. You can take a look here how simple waiting method implementation can look:

console/frontend/packages/console-shared/src/test-utils/utils.ts

Line 135 in 41bb8cb

export const waitForCount = (elementArrayFinder: ElementArrayFinder, targetCount: number) => {

and here how it's used:

console/frontend/packages/kubevirt-plugin/integration-tests/tests/vm.actions.scenario.ts

Line 130 in 41bb8cb

await browser.wait(until.and(waitForCount(resourceRows, 0)), PAGE_LOAD_TIMEOUT_SECS);

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.scenario.ts

rhrazdil · 2019-11-26T10:41:16Z

frontend/packages/noobaa-storage-plugin/integration-tests/views/noobaaDashboardPage.view.ts

@@ -0,0 +1,12 @@
+import { $, element, by } from 'protractor';
+
+export const obcCount = element(by.css('div[aria-label="Object Bucket Claim count"]'));


$() is an alias for element(by.css()), so these can be simplified by just using $().

openshift-ci-robot · 2020-05-13T07:36:15Z

@bipuladh: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2020-05-13T07:43:44Z

A reason for closing and reopening would help here @bipuladh .

bipuladh · 2020-05-13T07:45:12Z

/close

openshift-ci-robot · 2020-05-13T07:45:27Z

@bipuladh: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2020-06-18T08:09:00Z

/reopen

openshift-ci-robot · 2020-06-18T08:09:16Z

@bipuladh: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gnehapk · 2020-06-25T02:38:43Z

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.scenario.ts

+  });
+
+  it('Test at least one noobaa bucket is present', async () => {
+    await browser.wait(until.and(untilNoLoadersPresent));


Since this is already checked in beforeAll, why do you need to check it again here?

Its present at other places too

yes. For some reason, it fails without this.

gnehapk · 2020-06-25T02:47:31Z

frontend/packages/noobaa-storage-plugin/integration-tests/tests/overviewDashboard.scenario.ts

@@ -0,0 +1,106 @@
+import { execSync } from 'child_process';


The file should be named to something like object-service-dashboard instead of overviewDashboard

ebondare · 2020-06-26T07:18:29Z

...nd/packages/noobaa-storage-plugin/integration-tests/tests/objectSerivceDashboard.scenario.ts

+    await browser.wait(until.and(untilNoLoadersPresent));
+    await browser.wait(until.visibilityOf(healthOfMCG));
+    const color = healthOfMCG.getAttribute('fill');
+    expect(color).toBe('#486b00');


Wouldn't it be nicer to import the code for the green color from https://github.com/openshift/console/blob/master/frontend/packages/ceph-storage-plugin/integration-tests/utils/consts.ts ?

Makes sense. Thanks.

gnehapk · 2020-06-29T12:05:24Z

/lgtm

openshift-ci-robot · 2020-06-29T12:05:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, gnehapk, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/noobaa-storage-plugin/OWNERS~~ [bipuladh,gnehapk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-06-29T16:22:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot requested review from gnehapk and rawagner November 24, 2019 20:16

umangachapagain suggested changes Nov 25, 2019

View reviewed changes

bipuladh force-pushed the nb-dash-integration-test branch from 6c2fd14 to 687d550 Compare November 25, 2019 18:02

bipuladh requested a review from umangachapagain November 25, 2019 18:02

umangachapagain suggested changes Nov 26, 2019

View reviewed changes

bipuladh force-pushed the nb-dash-integration-test branch from 687d550 to 1a8e1d8 Compare November 26, 2019 09:18

bipuladh force-pushed the nb-dash-integration-test branch from 1a8e1d8 to def25a3 Compare November 26, 2019 09:38

bipuladh changed the title ~~[WIP] Added tests for object service dashboard page~~ Added tests for object service dashboard page Nov 26, 2019

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2019

bipuladh requested a review from umangachapagain November 26, 2019 09:39

openshift-ci-robot assigned rhrazdil Nov 26, 2019

bipuladh force-pushed the nb-dash-integration-test branch from def25a3 to dd06b0e Compare November 26, 2019 10:01

umangachapagain approved these changes Nov 26, 2019

View reviewed changes

rhrazdil suggested changes Nov 26, 2019

View reviewed changes

openshift-ci-robot closed this May 13, 2020

openshift-ci-robot reopened this Jun 18, 2020

bipuladh force-pushed the nb-dash-integration-test branch from 2c9a2ab to ed36fa9 Compare June 18, 2020 08:12

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2020

bipuladh force-pushed the nb-dash-integration-test branch 2 times, most recently from 6d5163a to f7d572f Compare June 24, 2020 16:17

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020

gnehapk reviewed Jun 25, 2020

View reviewed changes

bipuladh requested review from cloudbehl and gnehapk June 25, 2020 06:37

bipuladh force-pushed the nb-dash-integration-test branch from f7d572f to 8e972a5 Compare June 25, 2020 06:48

gnehapk approved these changes Jun 26, 2020

View reviewed changes

ebondare reviewed Jun 26, 2020

View reviewed changes

Add tests for Noobaa Dashboard

7c598b9

bipuladh force-pushed the nb-dash-integration-test branch from 8e972a5 to 7c598b9 Compare June 26, 2020 09:00

bipuladh requested a review from ebondare June 26, 2020 09:06

openshift-ci-robot assigned gnehapk Jun 29, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020

openshift-merge-robot merged commit 7083b9c into openshift:master Jun 29, 2020

spadgett added this to the v4.6 milestone Jul 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added tests for object service dashboard page #3555

Added tests for object service dashboard page #3555

bipuladh commented Nov 24, 2019 •

edited

umangachapagain Nov 25, 2019

bipuladh Nov 25, 2019

umangachapagain Nov 25, 2019

bipuladh Nov 25, 2019

umangachapagain Nov 26, 2019

gnehapk commented Nov 26, 2019

umangachapagain left a comment

umangachapagain Nov 26, 2019

umangachapagain commented Nov 26, 2019

bipuladh commented Nov 26, 2019

umangachapagain commented Nov 26, 2019

bipuladh commented Nov 26, 2019

umangachapagain left a comment

bipuladh commented Nov 26, 2019

rhrazdil left a comment

rhrazdil Nov 26, 2019 •

edited

rhrazdil Nov 26, 2019

openshift-ci-robot commented May 13, 2020

afreen23 commented May 13, 2020

bipuladh commented May 13, 2020

openshift-ci-robot commented May 13, 2020

bipuladh commented Jun 18, 2020

openshift-ci-robot commented Jun 18, 2020

gnehapk Jun 25, 2020

gnehapk Jun 25, 2020

bipuladh Jun 25, 2020

gnehapk Jun 25, 2020

ebondare Jun 26, 2020

bipuladh Jun 26, 2020

gnehapk commented Jun 29, 2020

openshift-ci-robot commented Jun 29, 2020

openshift-bot commented Jun 29, 2020

	it('Creates an Object Bucket Claim and test equality', async () => {
	it('Creates an Object Bucket Claim and tests equality', async () => {

		@@ -0,0 +1,12 @@
		import { $, element, by } from 'protractor';

		export const obcCount = element(by.css('div[aria-label="Object Bucket Claim count"]'));

Added tests for object service dashboard page #3555

Added tests for object service dashboard page #3555

Conversation

bipuladh commented Nov 24, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnehapk commented Nov 26, 2019

umangachapagain left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

umangachapagain commented Nov 26, 2019

bipuladh commented Nov 26, 2019

umangachapagain commented Nov 26, 2019

bipuladh commented Nov 26, 2019

umangachapagain left a comment

Choose a reason for hiding this comment

bipuladh commented Nov 26, 2019

rhrazdil left a comment

Choose a reason for hiding this comment

rhrazdil Nov 26, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci-robot commented May 13, 2020

afreen23 commented May 13, 2020

bipuladh commented May 13, 2020

openshift-ci-robot commented May 13, 2020

bipuladh commented Jun 18, 2020

openshift-ci-robot commented Jun 18, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnehapk commented Jun 29, 2020

openshift-ci-robot commented Jun 29, 2020

openshift-bot commented Jun 29, 2020

bipuladh commented Nov 24, 2019 •

edited

rhrazdil Nov 26, 2019 •

edited