kubevirt: add source and remove type from disks table

[atiratree]

changing according to our recent UI discussions

@glekner @matthewcarleton

btw, shouldn't we keep the name first?

[atiratree]

/retest

[matthewcarleton]

@suomiy let me look at the order again. This could just be an artifact of the old Create VM Flow where we had an inline edit flow where source needed to be first because it would determine which fields followed when editing/creating a disk.

[matthewcarleton]

@suomiy I think we could now align better with the console by putting the name first. We'll still want to keep the source first in the modal b/c it impacts other fields.

[atiratree]

fixed, name comes first now

[glekner]

maybe the safe accessing can move to getSource() ?

[atiratree]

fixed

[rawagner]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/kubevirt-plugin/OWNERS [rawagner,suomiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[matthewcarleton]

fixed, name comes first now

ok, this means we'll want to ensure it's the same everywhere now right (Name first)?

[atiratree]

@suomiy I think we could now align better with the console by putting the name first. We'll still want to keep the source first in the modal b/c it impacts other fields.

ok, this means we'll want to ensure it's the same everywhere now right (Name first)?

not sure what you mean by that? The names are first in all tables, but not in the modals.

[matthewcarleton]

@suomiy I think we could now align better with the console by putting the name first. We'll still want to keep the source first in the modal b/c it impacts other fields.

ok, this means we'll want to ensure it's the same everywhere now right (Name first)?

not sure what you mean by that? The names are first in all tables, but not in the modals.

ok, we have in some of our designs (maybe just CD-ROMs right now) where the source is still first so maybe that's the only one we need to update which I can do. FYI @glekner