Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pod and network utilization to overview dashboard #3574

Merged
merged 1 commit into from Dec 12, 2019
Merged

Add pod and network utilization to overview dashboard #3574

merged 1 commit into from Dec 12, 2019

Conversation

rawagner
Copy link
Contributor

network_pods

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard labels Nov 26, 2019
@rawagner
Copy link
Contributor Author

rawagner commented Dec 9, 2019

/assign @kyoto

please take a look

paulfantom
paulfantom suggested changes Dec 10, 2019
View reviewed changes
Copy link

@paulfantom paulfantom left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated promQL queries and those are ok.
Some minor comments in regards to variable naming :)

frontend/public/components/dashboard/dashboards-page/overview-dashboard/queries.ts
@@ -53,6 +60,9 @@ const overviewQueries = {
[OverviewQuery.STORAGE_UTILIZATION]:
'(sum(node_filesystem_size_bytes) - sum(node_filesystem_free_bytes))',
[OverviewQuery.STORAGE_TOTAL]: 'sum(node_filesystem_size_bytes)',
[OverviewQuery.POD_UTILIZATION]: 'count(kube_pod_info)',
[OverviewQuery.NETWORK_UTILIZATION]:
'sum(rate(container_network_receive_bytes_total{container="POD",pod!=""}[5m]) + rate(container_network_transmit_bytes_total{container="POD",pod!=""}[5m]))',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This is the first time I see network utilization measured as a sum of TX and RX. Usually, utilization is calculated as a percent of some maximum value, in case of network formula is utilization % = (data bits x 100) / (bandwidth x interval).

frontend/public/components/dashboard/dashboards-page/overview-dashboard/queries.ts
@@ -53,6 +60,9 @@ const overviewQueries = {
[OverviewQuery.STORAGE_UTILIZATION]:
'(sum(node_filesystem_size_bytes) - sum(node_filesystem_free_bytes))',
[OverviewQuery.STORAGE_TOTAL]: 'sum(node_filesystem_size_bytes)',
[OverviewQuery.POD_UTILIZATION]: 'count(kube_pod_info)',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is giving a number of pods in cluster, not exactly utilization.

@kyoto
Copy link
Member

kyoto commented Dec 10, 2019

/lgtm

@paulfantom's feedback can be addressed with a follow-up

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, paulfantom, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.4 milestone Dec 10, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rawagner
Copy link
Contributor Author

/retest

5 similar comments
@rawagner
Copy link
Contributor Author

/retest

@rawagner
Copy link
Contributor Author

/retest

@rawagner
Copy link
Contributor Author

/retest

@rawagner
Copy link
Contributor Author

/retest

@rawagner
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rawagner
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 375cb04 into openshift:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfantom paulfantom paulfantom approved these changes

@andybraren andybraren Awaiting requested review from andybraren

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@kyoto kyoto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rawagner @kyoto @openshift-ci-robot @openshift-bot @paulfantom @spadgett @openshift-merge-robot