Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CNV activities #3577

Merged
merged 1 commit into from Dec 4, 2019
Merged

Add CNV activities #3577

merged 1 commit into from Dec 4, 2019

Conversation

rawagner
Copy link
Contributor

  • Disk import
  • v2v import

v2v_act

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin labels Nov 26, 2019
@andybraren
Copy link
Contributor

@matthewcarleton @Ranelim @yfrimanm ^ 🎉

mareklibra
mareklibra reviewed Dec 3, 2019
View reviewed changes
...tend/packages/kubevirt-plugin/src/components/dashboards-page/overview-dashboard/activity.tsx Outdated
import { referenceForModel } from '@console/internal/module/k8s';
import { VirtualMachineModel } from '../../../models';

export const DiskImportActivity = ({ resource }) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type added

...tend/packages/kubevirt-plugin/src/components/dashboards-page/overview-dashboard/activity.tsx Outdated
</ActivityProgress>
);

export const V2VImportActivity = ({ resource }) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type added

...tend/packages/kubevirt-plugin/src/components/dashboards-page/overview-dashboard/activity.tsx Outdated
export const V2VImportActivity = ({ resource }) => (
<ActivityProgress
title="Importing VM (v2v)"
progress={parseInt(_.get(resource.metadata.annotations, 'v2vConversionProgress', 0), 10)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can resource be undefined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cannot. This is a resource which is fetched from k8s (definition is https://github.com/openshift/console/pull/3577/files#diff-ebd2d0d608781a3c30e4c97813f813c2R284 ), run through isActivity for given activity like https://github.com/openshift/console/pull/3577/files#diff-ebd2d0d608781a3c30e4c97813f813c2R289 or https://github.com/openshift/console/pull/3577/files#diff-ebd2d0d608781a3c30e4c97813f813c2R306 which if returns true, then the resource is passed to component.

...tend/packages/kubevirt-plugin/src/components/dashboards-page/overview-dashboard/activity.tsx Outdated
>
<ResourceLink
kind={referenceForModel(VirtualMachineModel)}
name={resource.metadata.ownerReferences[0].name}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is presence of ownerReference[0] guaranteed? I understand how it is being created recently. But I would suggest to be more defensive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. Im more defensive now

@rawagner
Copy link
Contributor Author

rawagner commented Dec 3, 2019

/retest

@mareklibra
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added this to the v4.4 milestone Dec 3, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rawagner
Copy link
Contributor Author

rawagner commented Dec 3, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot added a commit that referenced this pull request Dec 4, 2019
@openshift-merge-robot
Merge pull request #3577 from rawagner/cnv_activities
cb1aa97 
Add CNV activities
@openshift-merge-robot openshift-merge-robot merged commit cb1aa97 into openshift:master Dec 4, 2019
@openshift-merge-robot openshift-merge-robot merged commit 501783c into openshift:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mareklibra mareklibra mareklibra left review comments

@jelkosz jelkosz Awaiting requested review from jelkosz

Assignees

@mareklibra mareklibra

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rawagner @andybraren @mareklibra @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot