Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node maintenance activity #3579

Merged
merged 1 commit into from Dec 3, 2019
Merged

Add node maintenance activity #3579

merged 1 commit into from Dec 3, 2019

Conversation

rawagner
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/metal3 Related to metal3-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 26, 2019
jtomasek
jtomasek suggested changes Nov 28, 2019
View reviewed changes
Copy link

@jtomasek jtomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to show this activity on the BMH dashboard as well. It can be done in a separate PR though.

frontend/packages/metal3-plugin/src/plugin.ts Outdated
import(
'./components/maintenance/MaintenanceDashboardActivity' /* webpackChunkName: "node-maintenance" */
).then((m) => m.default),
required: FLAGS.BAREMETAL,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required: FLAGS.BAREMETAL,
required: [FLAGS.BAREMETAL, Metal3_FLAG],

frontend/packages/metal3-plugin/src/plugin.ts Outdated
kind: referenceForModel(NodeMaintenanceModel),
prop: 'maintenances',
},
isActivity: (resource) => _.get(resource.status, 'phase') !== 'Succeeded',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC the maintenance phase can be Running|Success|Error so I'd go for

Suggested change
isActivity: (resource) => _.get(resource.status, 'phase') !== 'Succeeded',
isActivity: (resource) => _.get(resource.status, 'phase') === 'Running',

just to be sure.

@rawagner
Copy link
Contributor Author

rawagner commented Dec 2, 2019

@jtomasek fixed both. I think we will want to show maintenance progress in Status card for BMH dashboard. I will create a separate PR

@jtomasek
Copy link

jtomasek commented Dec 2, 2019

/retest

@jtomasek
Copy link

jtomasek commented Dec 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtomasek, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e1fee98 into openshift:master Dec 3, 2019
@spadgett spadgett added this to the v4.4 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtomasek jtomasek jtomasek approved these changes

@honza honza Awaiting requested review from honza

Assignees

@jtomasek jtomasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/metal3 Related to metal3-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rawagner @jtomasek @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot