topology: add delay to setting hover states #3584
Conversation
openshift-ci-robot
added
size/S
jeff-phillips-18
force-pushed
the
topology-hover
branch
from
76146cd
to
919ba31
Compare
|
@jeff-phillips-18 So the idea is to just add a hover out delay for the connector? Because we still need a configurable delay for hover in. |
jeff-phillips-18
force-pushed
the
topology-hover
branch
from
919ba31
to
bd87152
Compare
openshift-ci-robot
added
size/M
|
@christianvogt The delay is for both in and out, and it is configurable. Didn't think we needed it to be configurable separately for the two as it acts a bit strange when you do that (two nodes highlighted briefly). |
| delayHandle = clearTimeout(unsetHandle.current); | ||
| setHover(true); | ||
| }, delay); | ||
| clearTimeout(unsetHandle.current); |
There was a problem hiding this comment.
Trying to recall why this is inside the timeout and not outside. However by you clearing the timeout above, we don't need this here.
There was a problem hiding this comment.
it is needed if the timer is created during the hover delay, not needed below when there is no delay.
| }, delay); | ||
| clearTimeout(unsetHandle.current); | ||
| setHover(newState); | ||
| }, timeoutDelay); | ||
| } else { | ||
| clearTimeout(unsetHandle.current); |
There was a problem hiding this comment.
This line is redundant with line 30.
| @@ -49,18 +56,19 @@ const useHover = <T extends Element>( | |||
| node.removeEventListener('mouseenter', onMouseEnter); | |||
| node.removeEventListener('mouseleave', onMouseLeave); | |||
| clearTimeout(delayHandle); | |||
| delayHandle = null; | |||
| @@ -6,6 +6,7 @@ const useHover = <T extends Element>( | |||
| ): [boolean, (node: T) => (() => void) | undefined] => { | |||
| const [hover, setHover] = React.useState<boolean>(false); | |||
| const unmountRef = React.useRef(false); | |||
| const timeoutDelay = delay !== undefined ? delay : 200; | |||
There was a problem hiding this comment.
Use a default value in the param
delay? = 200,
I'd like to see both a separate delayIn and delayOut but we can add as needed in future.
Addresses usability issue trying to create a new connection.
jeff-phillips-18
force-pushed
the
topology-hover
branch
from
bd87152
to
d51e2c5
Compare
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Addresses usability issue trying to create a new connection.
Resolves https://jira.coreos.com/browse/ODC-2210