Bug 1776131: Exclude Conditions from statusDescriptors so they don't … #3587
Conversation
|
@rhamilto: This pull request references Bugzilla bug 1776131, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
frontend/packages/operator-lifecycle-manager/src/components/operand.tsx
Outdated
Show resolved
Hide resolved
|
/cherrypick release-4.3 |
|
@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@rhamilto: This pull request references Bugzilla bug 1776131, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/retest Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
| const statusDescriptors = _.get<Descriptor[]>(thisDefinition, 'statusDescriptors', []); | ||
| const statusDescriptors = _.get<Descriptor[]>(thisDefinition, 'statusDescriptors', []).filter( | ||
| // exclude Conditions since they are included in their own section | ||
| (descriptor) => descriptor.displayName !== 'Conditions', |
There was a problem hiding this comment.
We should check path rather than displayName
| (descriptor) => descriptor.displayName !== 'Conditions', | |
| (descriptor) => descriptor.path !== 'conditions', |
There was a problem hiding this comment.
We might want to skip our generic conditions handling if there's a status descriptor that's not urn:alm:descriptor:io.kubernetes.conditions. I wonder if we should just remove that and ask operators to specify the descriptor.
There was a problem hiding this comment.
Updated. Thanks, @spadgett
|
/lgtm cancel |
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@rhamilto: All pull requests linked via external trackers have merged. Bugzilla bug 1776131 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rhamilto: new pull request created: #3634 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…appear twice
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1776131