Bug 1772565: Egress legend color mismatch with bars #3604
Conversation
|
@afreen23: This pull request references Bugzilla bug 1772565, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
openshift-ci-robot
added
size/S
|
@afreen23 lint it |
|
/bugzilla refresh |
|
@afreen23: This pull request references Bugzilla bug 1772565, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@afreen23: This pull request references Bugzilla bug 1772565, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1772565 Bar chart colors are assigned as per the bar group. Previously only one `ChartBar` was being used which was causing only color to pick for all bars in egress. The fix is to have seperate bar for each group and adjust offset to center it with x axis ticks. This is done by having `ChartBar` component for each single bar rather than one `ChartBar` for all bars. Signed-off-by: Afreen Rahman <afrahman@redhat.com>
afreen23
force-pushed
the
data-consumption-labels-fix
branch
from
1d1355c
to
166d7b6
Compare
|
/retest |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, bipuladh, gnehapk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-4.3 |
|
@afreen23: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@afreen23 can you add before after screenshots of things changed |
|
@afreen23: All pull requests linked via external trackers have merged. Bugzilla bug 1772565 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@afreen23: new pull request created: #3641 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1772565
Bar chart colors are assigned as per the bar group.
Previously only one
ChartBarwas being used which was causing only color to pick for all bars in egress.The fix is to have seperate bar for each group and adjust offset to center it with x axis ticks.
This is done by having
ChartBarcomponent for each single bar rather than oneChartBarfor all bars.