Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1777969: fix(knative-icons): show icons for event sources #3608

Merged

Conversation

nemesis09
Copy link
Contributor

This PR -

@openshift-ci-robot openshift-ci-robot added component/knative Related to knative-plugin size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2019
@christianvogt
Copy link
Contributor

@nemesis09 please fix the linting errors

Tested PR and icons show up

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, nemesis09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2019
@nemesis09
Copy link
Contributor Author

/cherrypick release-4.3

@openshift-cherrypick-robot

@nemesis09: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@nemesis09: new pull request created: #3613

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christianvogt
Copy link
Contributor

/retitle Bug 1777969: fix(knative-icons): show icons for event sources

@openshift-ci-robot openshift-ci-robot changed the title fix(knative-icons): show icons for event sources Bug 1777969: fix(knative-icons): show icons for event sources Dec 2, 2019
@openshift-ci-robot
Copy link
Contributor

@nemesis09: All pull requests linked via external trackers have merged. Bugzilla bug 1777969 has been moved to the MODIFIED state.

In response to this:

Bug 1777969: fix(knative-icons): show icons for event sources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants