Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.3] Bug 1777178: Query Browser: Fix Switch to enable when inserting example query #3635

Merged
merged 1 commit into from Dec 3, 2019
Merged

[release-4.3] Bug 1777178: Query Browser: Fix Switch to enable when inserting example query #3635

merged 1 commit into from Dec 3, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3592

/assign spadgett

@kyoto
Query Browser: Fix Switch to enable when inserting example query
71bd933 
Inserting an example query sets `isEnalbed` to `true` for the query in
Redux, but that was not causing the `Switch` to update.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 3, 2019
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1777177, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1777177: Query Browser: Fix Switch to enable when inserting example query

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/core Related to console core functionality component/monitoring Related to monitoring labels Dec 3, 2019
@kyoto
Copy link
Member

kyoto commented Dec 3, 2019

/retitle [release-4.3] Bug 1777178: Query Browser: Fix Switch to enable when inserting example query

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1777177: Query Browser: Fix Switch to enable when inserting example query [release-4.3] Bug 1777178: Query Browser: Fix Switch to enable when inserting example query Dec 3, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1777178, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-4.3] Bug 1777178: Query Browser: Fix Switch to enable when inserting example query

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 3, 2019
@spadgett spadgett added this to the v4.3 milestone Dec 3, 2019
@spadgett
Copy link
Member

spadgett commented Dec 3, 2019

/retest

spadgett
spadgett approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@openshift-merge-robot openshift-merge-robot merged commit f6ca8dd into openshift:release-4.3 Dec 3, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1777178 has been moved to the MODIFIED state.

In response to this:

[release-4.3] Bug 1777178: Query Browser: Fix Switch to enable when inserting example query

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @kyoto @spadgett @openshift-merge-robot