Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1749469: Align event types with k8s #3642

Merged
merged 1 commit into from Dec 5, 2019
Merged

Bug 1749469: Align event types with k8s #3642

merged 1 commit into from Dec 5, 2019

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Dec 3, 2019

Console currently uses Info/Error types for Events but k8s has Normal/Warning. This PR aligns terminology with k8s and also changes colors from red to yellow.

Before this change Event was categorized on basis of words in reason field - if it contained any of error, failed, unhealthy, nodenotready than the event was considered as error type - after this change we categorize events by type field.

events
events_dashboard

This change is based on the feedback for 4.3 dashboards https://docs.google.com/document/d/1YfS8QXLvm1Iw2M-9P3dPNrmS6rOHJkMbqAbbLYO53QE/edit#heading=h.ksft1vlhuehh

@spadgett @andybraren

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 3, 2019
@andybraren
Copy link
Contributor

andybraren commented Dec 3, 2019 •
edited

Nice! We talked about this change a while ago @spadgett, and this seems to align us closer to what users see in the CLI.

Maybe we should change the "All Categories" dropdown to say "All Types" instead.

image

@spadgett spadgett changed the title Align event types with k8s Bug 1749469: Align event types with k8s Dec 3, 2019
@openshift-ci-robot
Copy link
Contributor

@rawagner: This pull request references Bugzilla bug 1749469, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1749469: Align event types with k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 3, 2019
spadgett
spadgett approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@spadgett
Copy link
Member

spadgett commented Dec 3, 2019

/hold
for @andybraren's comment

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2019
@rawagner
Copy link
Contributor Author

rawagner commented Dec 4, 2019

Nice! We talked about this change a while ago @spadgett, and this seems to align us closer to what users see in the CLI.

Maybe we should change the "All Categories" dropdown to say "All Types" instead.

image

The first dropdown also says All Types so I changed that to All Resources

all_types

rawagner
rawagner commented Dec 4, 2019
View reviewed changes
frontend/packages/console-shared/src/components/dashboard/events-card/EventItem.tsx
@@ -1,13 +1,13 @@
import * as React from 'react';
import { RedExclamationCircleIcon } from '@console/shared';
import { categoryFilter, getLastTime } from '@console/internal/components/events';
import { typeFilter, getLastTime } from '@console/internal/components/events';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this file will be removed (events card is replaced by activity card) so I did only minimal change to pass the compilation

@andybraren
Copy link
Contributor

The first dropdown also says All Types so I changed that to All Resources

Ah good catch, looks great.

spadgett
spadgett approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 4, 2019
@spadgett
Copy link
Member

spadgett commented Dec 4, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.4 milestone Dec 4, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 75a1b35 into openshift:master Dec 5, 2019
@openshift-ci-robot
Copy link
Contributor

@rawagner: All pull requests linked via external trackers have merged. Bugzilla bug 1749469 has been moved to the MODIFIED state.

In response to this:

Bug 1749469: Align event types with k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rawagner @andybraren @openshift-ci-robot @spadgett @openshift-bot @openshift-merge-robot