Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to TypeScript 3.7.2 #3651

Merged
merged 2 commits into from Dec 6, 2019
Merged

Update to TypeScript 3.7.2 #3651

merged 2 commits into from Dec 6, 2019

Conversation

TheRealJon
Copy link
Member

Update to TypeScript 3.7.2

Fix breaking changes:

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 3, 2019
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/olm Related to OLM component/shared Related to console-shared labels Dec 3, 2019
@spadgett
Copy link
Member

spadgett commented Dec 3, 2019

I'd suggest putting the Protractor changes into a separate commit we can revert later. We should open an issue to track.

@TheRealJon
Copy link
Member Author

/retest

spadgett
spadgett approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

It's too bad we lose type checking for Protractor, but I don't see a way around it. It's simple enough to revert that commit when a new Protractor version is released. Thanks @TheRealJon 👍

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Dec 4, 2019

Last failure might have been a legitimate error:

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_console/3651/pull-ci-openshift-console-master-e2e-gcp-console/5198/artifacts/e2e-gcp-console/gui_test_screenshots/390fd8b409294fa38d7869a4f2d91976.png

[SEVERE] https://console-openshift-console.apps.ci-op-wr98g9z5-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-7dd1ff79f83106a95b50.min.js 132:71742 RangeError: Invalid array length
    at a (https://console-openshift-console.apps.ci-op-wr98g9z5-75d12.origin-ci-int-gce.dev.openshift.com/static/main-chunk-fbba48616d6dc5715fd0.min.js:1:428648)
    at https://console-openshift-console.apps.ci-op-wr98g9z5-75d12.origin-ci-int-gce.dev.openshift.com/static/main-chunk-fbba48616d6dc5715fd0.min.js:1:430286
    at Ra (https://console-openshift-console.apps.ci-op-wr98g9z5-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-7dd1ff79f83106a95b50.min.js:133:55337)
    at Kc (https://console-openshift-console.apps.ci-op-wr98g9z5-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-7dd1ff79f83106a95b50.min.js:133:98261)
    at Nc (https://console-openshift-console.apps.ci-op-wr98g9z5-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-7dd1ff79f83106a95b50.min.js:133:84008)
    at Dc (https://console-openshift-console.apps.ci-op-wr98g9z5-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-7dd1ff79f83106a95b50.min.js:133:81035)
    at Ac (https://console-openshift-console.apps.ci-op-wr98g9z5-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-7dd1ff79f83106a95b50.min.js:133:79608)
    at https://console-openshift-console.apps.ci-op-wr98g9z5-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-7dd1ff79f83106a95b50.min.js:133:41759
    at e.unstable_runWithPriority (https://console-openshift-console.apps.ci-op-wr98g9z5-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-7dd1ff79f83106a95b50.min.js:141:3878)
    at so (https://console-openshift-console.apps.ci-op-wr98g9z5-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-7dd1ff79f83106a95b50.min.js:133:41488)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.4 milestone Dec 4, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Dec 4, 2019

/lgtm cancel
Last two runs have consistently failed the same test. I don't believe this is a flake.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2019
@spadgett spadgett added the area/dependency Issues or PRs related to dependency changes label Dec 4, 2019
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@spadgett
Copy link
Member

spadgett commented Dec 5, 2019

/lgtm

Last run passed. Looks like this was a flake.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 08d06cb into openshift:master Dec 6, 2019
@TheRealJon TheRealJon deleted the typescript-3.7 branch December 6, 2019 14:13
@spadgett spadgett added kind/dependency-change Categorizes issue or PR as related to changing dependencies and removed area/dependency Issues or PRs related to dependency changes labels Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/olm Related to OLM component/shared Related to console-shared kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TheRealJon @spadgett @openshift-bot @openshift-ci-robot @openshift-merge-robot