Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1772814: Add required class to form <h3> heading that contains, at least, 1 or more required fields #3654

Merged
merged 1 commit into from Dec 6, 2019
Merged

Bug 1772814: Add required class to form <h3> heading that contains, at least, 1 or more required fields #3654

merged 1 commit into from Dec 6, 2019

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Dec 3, 2019

Set explicit font-size and position, so that asterisk is consistent to usage on <label>

fix https://bugzilla.redhat.com/show_bug.cgi?id=1772814
Screen Shot 2019-12-03 at 4 26 28 PM

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/core Related to console core functionality labels Dec 3, 2019
rhamilto
rhamilto approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.4 milestone Dec 4, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sg00dwin
Copy link
Member Author

sg00dwin commented Dec 4, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@sg00dwin
Copy link
Member Author

sg00dwin commented Dec 5, 2019

/retest

1 similar comment
@sg00dwin
Copy link
Member Author

sg00dwin commented Dec 5, 2019

/retest

@sg00dwin
Copy link
Member Author

sg00dwin commented Dec 5, 2019

@rhamilto please add another lgtm

@rhamilto
Copy link
Member

rhamilto commented Dec 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b689389 into openshift:master Dec 6, 2019
@sg00dwin sg00dwin deleted the required-icon branch December 9, 2019 21:07
@rhamilto rhamilto changed the title Add required class to form <h3> heading that contains, at least, 1 or more required fields Bug 1772814: Add required class to form <h3> heading that contains, at least, 1 or more required fields Feb 5, 2020
@rhamilto
Copy link
Member

rhamilto commented Feb 5, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@rhamilto: Bugzilla bug 1772814 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@sg00dwin: All pull requests linked via external trackers have merged. Bugzilla bug 1772814 has been moved to the MODIFIED state.

In response to this:

Bug 1772814: Add required class to form

heading that contains, at least, 1 or more required fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sg00dwin @openshift-bot @rhamilto @openshift-ci-robot @spadgett @openshift-merge-robot