Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Link descriptor Reference to README file and add statusDescriptor section #3658

Merged
merged 2 commits into from Jan 3, 2020
Merged

[Doc] Link descriptor Reference to README file and add statusDescriptor section #3658

merged 2 commits into from Jan 3, 2020

Conversation

tlwu2013
Copy link
Contributor

@tlwu2013 tlwu2013 commented Dec 4, 2019 •
edited

Doc only changes:

  1. Add a link to OLM Descriptor Reference from the Descriptor README file.
  2. Add "statusDescriptors" section on OLM Descriptor Reference.

@openshift-ci-robot
Copy link
Contributor

Hi @tlwu2013. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/olm Related to OLM labels Dec 4, 2019
@tlwu2013 tlwu2013 force-pushed the add-reference-doc-link-to-readme branch from 1b59d98 to bbfcf49 Compare December 4, 2019 02:01
@tlwu2013
Copy link
Contributor Author

tlwu2013 commented Dec 4, 2019

Hey @spadgett (cc @alimobrem ),

Can you help review this doc-only PR? Thanks!
This PR is for adding a link to the Reference guide on the Descriptor README file.

@tlwu2013 @spadgett
Update frontend/packages/operator-lifecycle-manager/src/components/de…
b6f8f92 
…scriptors/README.md

Co-Authored-By: Sam Padgett <spadgett@redhat.com>
@tlwu2013
Copy link
Contributor Author

tlwu2013 commented Dec 5, 2019

You're right @spadgett! We should use the relative link so that it always works regardless of which branch users are looking at. Thanks for catching this, Sam!

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2019
@tlwu2013
Copy link
Contributor Author

tlwu2013 commented Dec 13, 2019 •
edited

Hey @spadgett / @benjaminapetersen ,

Is this doc-only PR good to be merged? Much appreciated!

spadgett
spadgett approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-phillips-18, spadgett, tlwu2013

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

/retest

1 similar comment
@benjaminapetersen
Copy link
Contributor

/retest

@spadgett
Copy link
Member

spadgett commented Jan 2, 2020

/ok-to-test
/retest

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit 00cfdb4 into openshift:master Jan 3, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tlwu2013 @openshift-ci-robot @spadgett @benjaminapetersen @jeff-phillips-18 @openshift-merge-robot