Bug 1779116: vm template should create url import dataVolumes on its creation

[atiratree]

• show URL provision source for templates
• provision source changed to Disk (Attach Cloned Disk) for vms created
  from such templates
• add warning to the template disk modal

@mareklibra @matthewcarleton Can you take a look?

As you can see bellow, I changed a provision source of VM to Disk to truthfully reflect the situation.

I added a warning to disk-modal in template creation to show the difference between template url and vm url.

Is this enough? Should I show this also in the general tab so the user knows what is going on? Or in the review?

Templates Creation

Inspecting the template source

Creating VM from the template

[openshift-ci-robot]

@suomiy: This pull request references Bugzilla bug 1779116, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1779116: vm template should create url import dataVolumes on its creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matthewcarleton]

@suomiy just so I know I understand this correctly:

1. User creates a template and the source is via a URL
2. Datavolume is created with what was provided via the URL
3. VM is created with that Datavolume and not via the URL from the template

[atiratree]

@suomiy just so I know I understand this correctly:
3. VM is created with that Datavolume and not via the URL from the template

yup, although VM clones the PVC and does not use the original Datavolume or original PVC ever again

I guess we should modify that disk modal message a bit?

[matthewcarleton]

@suomiy ya I'm wondering why we are alerting them of this. Is it something that should concern them? Is it just because this will take storage space so we want to let them know?

[atiratree]

Because the behaviour is different for VM and VM template and for other VM template datavolumes

[matthewcarleton]

Do you think we should be talking about DataVolumes here if we don't show them anywhere in the UI?

[atiratree]

Not sure. Maybe PVC should be enough? - but that takes a while before it is ready (datavolume implies that)

[matthewcarleton]

I wonder if we could do something like this:

Using PVC is a little odd too since we don't expose that in the VM currently.

[atiratree]

That is just a consequence and doesn't say what is going on currently. They might not even expect that some pvc gets allocated with the creation of template.

I think PVC should be ok, as that is a pretty common term in k8s. Datavolumes not so much - unless you are familiar with CDI,

[matthewcarleton]

ok. It would be nice eventually if we could surface the idea of a PVC in the creation flow.

[atiratree]

updated

[mareklibra]

/lgtm

I do not think we need to expose this back-end stuff to the user so explicitly.
IMO, (s)he do not care. A note in the documentation might be good enough.

But as this is already agreed, I am not against it.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/kubevirt-plugin/OWNERS [mareklibra,suomiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matthewcarleton]

@mareklibra I am relying on the developer perspective here to better understand the use case for this. I do think that exposing PVCs here don't really help a CNV user since they don't necessarily know what a PVC is and won't get a better understanding of that by creating a VM from this template. I don't feel strongly about showing/hiding this in general though.

[openshift-ci-robot]

@suomiy: All pull requests linked via external trackers have merged. Bugzilla bug 1779116 has been moved to the MODIFIED state.

In response to this:

Bug 1779116: vm template should create url import dataVolumes on its creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.