New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Fix developer catalog heights #3671
frontend: Fix developer catalog heights #3671
Conversation
Add class to developer catalog tiles and add maxTruncation prop.
It seems like we're truncating too early in these tiles. There is plenty of space below. It would be better to use line-clamp instead of arbitrary character lengths so it fills the available width. We have a mixin. https://github.com/openshift/console/blob/master/frontend/public/style/mixin/_line-clamp.scss |
We've removed the fading text style from other parts of context, so there's no reason to keep it in the catalog any longer imo. line-clamp with |
The tiles change width depending on the size of your browser window. I had set the truncation based on the narrowest width there. I need to make a change to the extension to let us apply this class to the description and remove the fade; I'll get on that. I'll update this PR with the extension upgrade once that's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks. We can look at the descriptions in a follow on.
/approve
/lgtm
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaianirh, rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add class from OperatorHub tiles to developer catalog tiles and add maxTruncation prop to these tiles.
Heads up @jcaianirh and @spadgett.