Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Fix developer catalog heights #3671

Merged

Conversation

rebeccaalpert
Copy link
Contributor

@rebeccaalpert rebeccaalpert commented Dec 4, 2019

Add class from OperatorHub tiles to developer catalog tiles and add maxTruncation prop to these tiles.

Screen Shot 2019-12-04 at 2 57 21 PM

Heads up @jcaianirh and @spadgett.

Add class to developer catalog tiles and add maxTruncation prop.
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/core Related to console core functionality labels Dec 4, 2019
@spadgett
Copy link
Member

spadgett commented Dec 4, 2019

It seems like we're truncating too early in these tiles. There is plenty of space below.

It would be better to use line-clamp instead of arbitrary character lengths so it fills the available width. We have a mixin.

https://github.com/openshift/console/blob/master/frontend/public/style/mixin/_line-clamp.scss

cc @christianvogt

@spadgett
Copy link
Member

spadgett commented Dec 4, 2019

We've removed the fading text style from other parts of context, so there's no reason to keep it in the catalog any longer imo. line-clamp with ... would be better.

@spadgett spadgett added the kind/bug Categorizes issue or PR as related to a bug. label Dec 4, 2019
@spadgett spadgett added this to the v4.4 milestone Dec 4, 2019
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Dec 4, 2019

The tiles change width depending on the size of your browser window. I had set the truncation based on the narrowest width there.

I need to make a change to the extension to let us apply this class to the description and remove the fade; I'll get on that. I'll update this PR with the extension upgrade once that's done.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks. We can look at the descriptions in a follow on.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2019
@spadgett
Copy link
Member

spadgett commented Dec 4, 2019

/retest

Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3f918bf into openshift:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants