Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header color in catalog page to match patternfly catalog view. #3675

Merged
merged 3 commits into from Dec 6, 2019
Merged

Fix header color in catalog page to match patternfly catalog view. #3675

merged 3 commits into from Dec 6, 2019

Conversation

jcaianirh
Copy link
Member

@jcaianirh jcaianirh commented Dec 4, 2019 •
edited

updated:

Screen Shot 2019-12-04 at 5 48 18 PM

mobile:
Screen Shot 2019-12-05 at 1 00 16 PM

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/core Related to console core functionality labels Dec 4, 2019
@spadgett
Copy link
Member

spadgett commented Dec 4, 2019

I'd think we'd want to tweak the .co-catalog-page margin as well so it is left-aligned with the header

@spadgett spadgett added this to the v4.4 milestone Dec 4, 2019
@jcaianirh
Copy link
Member Author

@spadgett updated the css to align the catalog-page to left align with header.

@spadgett
Copy link
Member

spadgett commented Dec 4, 2019

/retest

1 similar comment
@jcaianirh
Copy link
Member Author

/retest

@jcaianirh
Copy link
Member Author

@spadgett this is ready for approval

@spadgett
Copy link
Member

spadgett commented Dec 5, 2019

Margin is off at mobile widths:

OperatorHub · OKD 2019-12-05 10-51-33

@jcaianirh
Copy link
Member Author

@spadgett fixed mobile alignment

@jcaianirh
Copy link
Member Author

/retest

spadgett
spadgett approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@spadgett
Copy link
Member

spadgett commented Dec 5, 2019

thanks @jcaianirh 👍

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit ee74e32 into openshift:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@rebeccaalpert rebeccaalpert rebeccaalpert approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcaianirh @spadgett @openshift-ci-robot @rebeccaalpert @openshift-merge-robot