Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Browser: Simplify Query Browser link URL logic #3678

Merged
merged 1 commit into from Dec 6, 2019
Merged

Query Browser: Simplify Query Browser link URL logic #3678

merged 1 commit into from Dec 6, 2019

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Dec 5, 2019 •
edited

Don't automatically switch to the Dev perspective when the user can't
access the Monitoring UI. Instead, navigate to the Dev perspective
version of the page, but leave the perspective set to Administrator (so
the page still loads, but the sidebar entry is not highlighted).

For the Dev perspective, stop getting the namespace from
getActiveNamespace because we can just link to /metrics and it will
automatically redirect to add the active namespace to the URL (or to
/metrics/all-namespaces if there is no active namespace).

Addressed feedback on #3541. WDYT @spadgett, @rawagner?

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality labels Dec 5, 2019
@kyoto
Copy link
Member Author

kyoto commented Dec 5, 2019

/assign @spadgett

@kyoto kyoto force-pushed the monitoring-simplify-query-browser-links branch from dd4adf3 to e8077e4 Compare December 5, 2019 09:28
@kyoto
Query Browser: Simplify Query Browser link URL logic
3b29b72 
Don't automatically switch to the Dev perspective when the user can't
access the Monitoring UI. Instead, navigate to the Dev perspective
version of the page, but leave the perspective set to Administrator (so
the page still loads, but the sidebar entry is not highlighted).

For the Dev perspective, stop getting the namespace from
`getActiveNamespace` because we can just link to `/metrics` and it will
automatically redirect to add the active namespace to the URL (or to
`/metrics/all-namespaces` if there is no active namespace).
@kyoto kyoto force-pushed the monitoring-simplify-query-browser-links branch from e8077e4 to 3b29b72 Compare December 5, 2019 09:34
@kyoto
Copy link
Member Author

kyoto commented Dec 5, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Dec 5, 2019

Instead, navigate to the Dev perspective
version of the page, but leave the perspective set to Administrator (so
the page still loads, but the sidebar entry is not highlighted).

We could add a startsWith to the admin nav item (but does it even display if the user doesn't have permission?)

spadgett
spadgett approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks, this looks simpler and is more in line with how we handle perspectives elsewhere. 👍

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.4 milestone Dec 5, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b71cae9 into openshift:master Dec 6, 2019
@kyoto kyoto deleted the monitoring-simplify-query-browser-links branch December 6, 2019 07:14
@kyoto kyoto mentioned this pull request Dec 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyoto @spadgett @openshift-ci-robot @openshift-bot @openshift-merge-robot