kubevirt: RDP integration test #3681

mareklibra · 2019-12-05T12:19:36Z

First RDP-related integration test pushed to discuss scope and approach.

mareklibra · 2019-12-05T12:20:03Z

rhrazdil

Only minor comments. IMO this is good and there's not more we can do in upstream.

rhrazdil · 2019-12-05T14:56:48Z

frontend/packages/kubevirt-plugin/integration-tests/views/consolesView.ts

@@ -0,0 +1,13 @@
+import { $, $$ } from 'protractor';
+
+export const consoleTypeSelectorId = '#console-type-selector';


These don't need to be called as methods, it's okay to have for example:

launchRemoteViewerButton = $('.remote-viewer-pf-launch-vv');

etc.

Done. But keeping function call for the ElementArrayFinder as I got stale reference error otherwise.

rhrazdil · 2019-12-05T15:00:21Z

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.consoles.rdp.scenario.ts

+        expect(launchRemoteDesktopButton().isEnabled()).toBe(true);
+
+        // there should be just the single laucher-pod
+        const hostIP = execSync("oc get pod -o yaml|grep hostIP| cut -d ':' -f 2")


use kubectl instead of oc please

rhrazdil · 2019-12-05T15:00:57Z

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.consoles.rdp.scenario.ts

+          .toString()
+          .trim();
+        const port = execSync(
+          `oc get service ${vm.name}-rdp -o yaml|grep nodePort| cut -d ':' -f 2`,


here as well

mareklibra · 2019-12-09T10:17:25Z

/retest

rhrazdil · 2019-12-09T12:45:15Z

/lgtm

openshift-bot · 2019-12-09T13:28:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-09T13:40:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-09T13:53:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mareklibra · 2019-12-10T09:22:24Z

Rebased

rhrazdil · 2019-12-10T12:14:18Z

/lgtm

openshift-ci-robot · 2019-12-10T12:14:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [mareklibra,rhrazdil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2019-12-10T12:37:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-10T12:52:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mareklibra · 2019-12-10T13:43:58Z

/retest

mareklibra · 2019-12-10T13:56:46Z

/retest

mareklibra · 2019-12-10T14:09:31Z

/retest

openshift-bot · 2019-12-10T18:28:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-10T19:08:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-10T20:25:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-10T20:38:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-10T21:04:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-10T23:40:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T06:23:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T07:15:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jelkosz · 2019-12-11T07:30:56Z

/test e2e-gcp-console

jelkosz · 2019-12-11T08:08:29Z

/test e2e-gcp-console

openshift-bot · 2019-12-11T08:33:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T09:12:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T09:28:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T09:38:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T09:51:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T10:17:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T10:43:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T11:35:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T12:14:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T12:27:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T12:40:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T14:24:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-11T15:29:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot requested review from atiratree and vojtechszocs December 5, 2019 12:19

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2019

openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Dec 5, 2019

rhrazdil suggested changes Dec 5, 2019

View reviewed changes

openshift-ci-robot assigned rhrazdil Dec 9, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2019

spadgett added this to the v4.4 milestone Dec 9, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2019

kubevirt: RDP integration test

35e8558

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2019

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2019

openshift-merge-robot merged commit 11d0192 into openshift:master Dec 11, 2019

		@@ -0,0 +1,13 @@
		import { $, $$ } from 'protractor';

		export const consoleTypeSelectorId = '#console-type-selector';

kubevirt: RDP integration test #3681

kubevirt: RDP integration test #3681

Conversation

mareklibra commented Dec 5, 2019

mareklibra commented Dec 5, 2019

rhrazdil left a comment • edited

Choose a reason for hiding this comment

rhrazdil Dec 5, 2019

Choose a reason for hiding this comment

mareklibra Dec 6, 2019

Choose a reason for hiding this comment

rhrazdil Dec 5, 2019

Choose a reason for hiding this comment

mareklibra Dec 6, 2019

Choose a reason for hiding this comment

rhrazdil Dec 5, 2019

Choose a reason for hiding this comment

mareklibra Dec 6, 2019

Choose a reason for hiding this comment

mareklibra commented Dec 9, 2019

rhrazdil commented Dec 9, 2019

openshift-bot commented Dec 9, 2019

openshift-bot commented Dec 9, 2019

openshift-bot commented Dec 9, 2019

mareklibra commented Dec 10, 2019

rhrazdil commented Dec 10, 2019

openshift-ci-robot commented Dec 10, 2019

openshift-bot commented Dec 10, 2019

openshift-bot commented Dec 10, 2019

mareklibra commented Dec 10, 2019

mareklibra commented Dec 10, 2019

mareklibra commented Dec 10, 2019

openshift-bot commented Dec 10, 2019

openshift-bot commented Dec 10, 2019

openshift-bot commented Dec 10, 2019

openshift-bot commented Dec 10, 2019

openshift-bot commented Dec 10, 2019

openshift-bot commented Dec 10, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

jelkosz commented Dec 11, 2019

jelkosz commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

openshift-bot commented Dec 11, 2019

rhrazdil left a comment •

edited