Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of Routes table #3697

Merged
merged 1 commit into from Dec 6, 2019

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Dec 5, 2019

Relies on #3691 for pf-u-w-16-on-lg.

cc: @bmignano

localhost_9000_k8s_all-namespaces_routes
localhost_9000_k8s_all-namespaces_routes (1)
localhost_9000_k8s_all-namespaces_routes (2)
localhost_9000_k8s_all-namespaces_routes (3)
localhost_9000_k8s_all-namespaces_routes (4)

@rhamilto rhamilto added this to the v4.4 milestone Dec 5, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality labels Dec 5, 2019
@bmignano
Copy link

bmignano commented Dec 5, 2019

LGTM!

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2019
@spadgett
Copy link
Member

spadgett commented Dec 6, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3356e57 into openshift:master Dec 6, 2019
@rhamilto rhamilto deleted the routes-cols branch December 9, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants