Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics to pod list and update columns #3703

Merged
merged 1 commit into from Dec 6, 2019
Merged

Add metrics to pod list and update columns #3703

merged 1 commit into from Dec 6, 2019

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Dec 6, 2019 •
edited

https://jira.coreos.com/browse/CONSOLE-1937
Depends on #3669

9 columns at the 2xl breakpoint (1450px) might be a little aggressive, but possible.

cc @rhamilto @bmignano @alimobrem

Screen Shot 2019-12-05 at 7 46 38 PM

Screen Shot 2019-12-05 at 7 54 15 PM

Screen Shot 2019-12-05 at 7 54 23 PM

Screen Shot 2019-12-05 at 7 54 29 PM

Screen Shot 2019-12-05 at 7 54 34 PM

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2019
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring labels Dec 6, 2019
@spadgett spadgett mentioned this pull request Dec 6, 2019
Closed
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/dev-console Related to dev-console and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 6, 2019
@spadgett
Copy link
Member Author

spadgett commented Dec 6, 2019

It feels better to me with 8 columns instead of 9.

Screen Shot 2019-12-05 at 8 37 20 PM

@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Dec 6, 2019
@spadgett spadgett force-pushed the pod-metrics branch 4 times, most recently from fae6709 to b6a1ffa Compare December 6, 2019 13:31
@spadgett spadgett changed the title [WIP] Add metrics to pod list and update columns Add metrics to pod list and update columns Dec 6, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2019
@spadgett spadgett added this to the v4.4 milestone Dec 6, 2019
@spadgett
Copy link
Member Author

spadgett commented Dec 6, 2019

/assign @rhamilto

@spadgett spadgett removed component/ceph Related to ceph-storage-plugin component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring labels Dec 6, 2019
rhamilto
rhamilto reviewed Dec 6, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! One breakpoint size tweak needed.

frontend/public/components/pod.tsx Outdated
// Only request metrics if the device's screen width is larger than the
// breakpoint where metrics are visible.
const showMetrics =
PROMETHEUS_BASE_PATH && PROMETHEUS_TENANCY_BASE_PATH && window.screen.width >= 992;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PROMETHEUS_BASE_PATH && PROMETHEUS_TENANCY_BASE_PATH && window.screen.width >= 992;
PROMETHEUS_BASE_PATH && PROMETHEUS_TENANCY_BASE_PATH && window.screen.width >= 1200;

Since the cols aren't visibile until xl

@bmignano
Copy link

bmignano commented Dec 6, 2019

This is awesome! In cases where users have Quay, could we include a Security column? Maybe replace Created? @beanh66

@spadgett
Copy link
Member Author

spadgett commented Dec 6, 2019

This is awesome! In cases where users have Quay, could we include a Security column? Maybe replace Created? @beanh66

That's a little tricky since the the container security support is through a plugin. We don't let plugins override standard resource table columns. It's something we could work out, but not possible today.

@spadgett
Copy link
Member Author

spadgett commented Dec 6, 2019

Thanks @rhamilto, updated

@rhamilto
Copy link
Member

rhamilto commented Dec 6, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bmignano
Copy link

bmignano commented Dec 6, 2019

Gotcha, thanks @spadgett ! The only other thing I think we were interested in potentially surfacing here is Restarts. I see it's very tight already but curious what your thoughts are? Could it replace node if that's less important to show? I think it'd be a fairly narrow column, unless there's some default min width we have to abide by.

@spadgett
Copy link
Member Author

spadgett commented Dec 6, 2019

/test analyze

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Dec 6, 2019

Gotcha, thanks @spadgett ! The only other thing I think we were interested in potentially surfacing here is Restarts. I see it's very tight already but curious what your thoughts are? Could it replace node if that's less important to show? I think it'd be a fairly narrow column, unless there's some default min width we have to abide by.

We might change readiness to show values like 1/1, which aligns with the CLI and frees up some space for restarts. We'd have to decide how to handle sorting, though.

Follow on PR OK?

@spadgett
Copy link
Member Author

spadgett commented Dec 6, 2019

/retest

@bmignano
Copy link

bmignano commented Dec 6, 2019

Follow on PR OK?

Sounds good to me, thanks!!

@spadgett spadgett mentioned this pull request Dec 6, 2019
Merged
rhamilto
rhamilto reviewed Dec 6, 2019
View reviewed changes
frontend/public/actions/ui.ts
}

export type PodMetrics = {
[metricKey: string]: {
[namepsace: string]: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[namepsace: string]: {
[namespace: string]: {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'll add to #3713

@openshift-merge-robot openshift-merge-robot merged commit 965463f into openshift:master Dec 6, 2019
@spadgett spadgett deleted the pod-metrics branch December 7, 2019 15:13
@andrewballantyne
Copy link
Contributor

For linking purposes (I mentioned it on the ticket), I believe this change caused https://issues.redhat.com/browse/CONSOLE-1981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@kyoto kyoto Awaiting requested review from kyoto

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@spadgett @bmignano @rhamilto @openshift-ci-robot @openshift-bot @andrewballantyne @openshift-merge-robot