Bug 1780629: Add <Status> to Operator resources
#3707
Conversation
openshift-ci-robot
added
size/M
openshift-ci-robot
added
the
approved
rhamilto
changed the title
<Status> to Operator resources<Status> to Operator resources
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@rhamilto: This pull request references Bugzilla bug 1780629, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-4.3 |
|
@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rhamilto: All pull requests linked via external trackers have merged. Bugzilla bug 1780629 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rhamilto: new pull request created: #3711 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -60,6 +71,9 @@ export const Status: React.FC<StatusProps> = ({ status, title, children, iconOnl | |||
| case 'Up to date': | |||
| return <SuccessStatus {...statusProps} />; | |||
|
|
|||
| case 'Created': | |||
| return <StatusIconAndText {...statusProps} icon={<GreenCheckCircleIcon />} />; | |||
There was a problem hiding this comment.
D'oh. case 'Created': sholuld have been added on line 68. Will fix in follow on.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1780629
Bonus: adds missing
ErrorImagePullandImagePullBackOffcases to<Status>