Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1798581: Add tests for pvc creation with different options #3708

Merged
merged 1 commit into from Feb 6, 2020
Merged

Bug 1798581: Add tests for pvc creation with different options #3708

merged 1 commit into from Feb 6, 2020

Conversation

ebondare
Copy link
Contributor

@ebondare ebondare commented Dec 6, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/ceph Related to ceph-storage-plugin labels Dec 6, 2019
@ebondare
Copy link
Contributor Author

ebondare commented Dec 6, 2019

/retest

rhrazdil
rhrazdil suggested changes Jan 21, 2020
View reviewed changes
frontend/packages/ceph-storage-plugin/integration-tests/tests/2-tests/pvc.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/2-tests/pvc.scenario.ts

describe('Test PVC creation with options.', () => {
beforeAll(async () => {
await browser.get(`${appHost}/`);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a bit safer to await isLoaded() here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isLoaded() function doesn't work here, because the page being loaded as default is Overview Dashboard, so I'd need dashboardIsLoaded()
But actually I wouldn't want the test to wait for the dashboard to be loaded, it might fail on https://bugzilla.redhat.com/show_bug.cgi?id=1753666 or just make the test run longer unnecessarily.
I do check that Persistent Volume Claims page is loaded at the beginning of each test as part of PVC creation function.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

frontend/packages/ceph-storage-plugin/integration-tests/tests/2-tests/pvc.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/views/pvc.view.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/views/pvc.view.ts Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jan 28, 2020
@bipuladh
Copy link
Contributor

/retest

rhrazdil
rhrazdil suggested changes Jan 29, 2020
View reviewed changes
Copy link

@rhrazdil rhrazdil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two comments, looks solid otherwise

frontend/packages/ceph-storage-plugin/integration-tests/views/pvc.view.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/views/pvc.view.ts Outdated Show resolved Hide resolved
@bipuladh
Copy link
Contributor

Please run the linter as well as squash the commits.

@rhrazdil
Copy link

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@rhrazdil
Copy link

/lgtm cancel
Squash the commits please

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@afreen23
Copy link
Contributor

afreen23 commented Feb 3, 2020

/retest

@afreen23
Copy link
Contributor

afreen23 commented Feb 3, 2020

/test analyze

shyRozen
shyRozen approved these changes Feb 3, 2020
View reviewed changes
frontend/packages/ceph-storage-plugin/integration-tests/views/pvc.view.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/pvc.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/pvc.scenario.ts Outdated
true,
);
await goToPersistentVolumeClaims();
await crudView.resourceRowsPresent();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the test uses expect to verify if test passes or not. Please convert the checks to expect statements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

frontend/packages/ceph-storage-plugin/integration-tests/views/pvc.view.ts Outdated
await inputPVCSize.sendKeys(newPvcSize);
await crudView.saveChangesBtn.click();
if (waitForBinding === true)
await browser.wait(until.textToBePresentInElement(pvcStatus, 'Bound'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this function in loop and there is problem because the first function expands storage section in the sidenav and then clicks persistent volume claim. The next time you run the function it collapse (instead of expand) the storage section and and hence doesn't find the persistent volume claim. I suggest to add a click on storage in the sidenav in the end of the function to prevent an error each time the function is running twice or more. Something like:

      click(element(by.cssContainingText('a[data-component="pf-nav-expandable"]','Storage')));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This comment got lost somehow, I didn't see it until today. I'll fix it in my next PR, will it be ok?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure Elana. Not urgent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please retry with the latest version of the function? I tried creating PVC a few times in a row, it worked correctly. I think one of the changes requested by Neha fixed this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to know that we are on the same page. It is not running the whole test in a loop. This will work for sure. It is importing the createNewPersistentVolumeClaim to another test and running it in a loop to create few PVCs. I'll test it later on if we are talking about the same scenario but I've checked the code and nothing has changed about this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I used createNewPersistentVolumeClaim a few times in a row inside a different test and couldn't reproduce the problem. Could you please show me your code?

@shyRozen
Copy link
Contributor

shyRozen commented Feb 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@shyRozen
Copy link
Contributor

shyRozen commented Feb 4, 2020

/test e2e-gcp-console

@shyRozen
Copy link
Contributor

shyRozen commented Feb 4, 2020

/assign @rhamilto

@rhrazdil
Copy link

rhrazdil commented Feb 5, 2020

Comment pointed out by @shyRozen can be addressed in a follow-up PR.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2020
@rhrazdil
Copy link

rhrazdil commented Feb 5, 2020

/test e2e-gcp-console

@ebondare ebondare changed the title Add tests for pvc creation with different options Bug 1798581: Add tests for pvc creation with different options Feb 5, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 5, 2020
@openshift-ci-robot
Copy link
Contributor

@ebondare: This pull request references Bugzilla bug 1798581, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1798581: Add tests for pvc creation with different options

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhrazdil
Copy link

rhrazdil commented Feb 5, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 5, 2020
@openshift-ci-robot
Copy link
Contributor

@rhrazdil: This pull request references Bugzilla bug 1798581, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor

bipuladh commented Feb 6, 2020

/approve

@bipuladh
Copy link
Contributor

bipuladh commented Feb 6, 2020

@rawagner Please have a look. Needs your approval.

@rawagner
Copy link
Contributor

rawagner commented Feb 6, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, ebondare, rawagner, rhrazdil, shyRozen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit e38a8b9 into openshift:master Feb 6, 2020
@openshift-ci-robot
Copy link
Contributor

@ebondare: All pull requests linked via external trackers have merged. Bugzilla bug 1798581 has been moved to the MODIFIED state.

In response to this:

Bug 1798581: Add tests for pvc creation with different options

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnehapk gnehapk gnehapk left review comments

@shyRozen shyRozen shyRozen approved these changes

@rhrazdil rhrazdil rhrazdil requested changes

@bipuladh bipuladh bipuladh left review comments

@a2batic a2batic Awaiting requested review from a2batic

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

Assignees

@rhamilto rhamilto

@shyRozen shyRozen

@rhrazdil rhrazdil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet