Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pfly to latest version 2019.10 released november 25 #3728

Merged
merged 1 commit into from Dec 9, 2019
Merged

Upgrade pfly to latest version 2019.10 released november 25 #3728

merged 1 commit into from Dec 9, 2019

Conversation

jcaianirh
Copy link
Member

@jcaianirh jcaianirh commented Dec 9, 2019 •
edited

Ran visual tests in chrome and edge browsers, ran unit tests.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 9, 2019
@jcaianirh
Copy link
Member Author

jcaianirh commented Dec 9, 2019 •
edited

Seeing a console error: vendors~main-chunk-19b2597918da0b5bb84d.min.js:145875 Error: <svg> attribute viewBox: Expected number, "0 0 null 70". on the dashboard page. Looks like a graphing issue. Spoke to Dan Labreque who mentioned that we upgraded our victory chart version hence the major version upgrade for pfly charts.
Update: @TheRealJon already working on this known issue.

@jcaianirh
Copy link
Member Author

/retest

@jcaianirh jcaianirh changed the title [WIP]: Upgrade pfly to latest version 2019.10 released november 25 Upgrade pfly to latest version 2019.10 released november 25 Dec 9, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2019
@jcaianirh
Copy link
Member Author

@spadgett haven't found any issues with firefox, chrome, edge with upgraded pf packages. All tests passing.

@spadgett spadgett added the area/dependency Issues or PRs related to dependency changes label Dec 9, 2019
@spadgett spadgett added this to the v4.4 milestone Dec 9, 2019
spadgett
spadgett approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit a5166dc into openshift:master Dec 9, 2019
@spadgett spadgett added kind/dependency-change Categorizes issue or PR as related to changing dependencies and removed area/dependency Issues or PRs related to dependency changes labels Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcaianirh @openshift-ci-robot @spadgett @openshift-merge-robot