Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align cd summary list with design #3742

Merged
merged 1 commit into from Dec 11, 2019
Merged

Align cd summary list with design #3742

merged 1 commit into from Dec 11, 2019
+7 −4

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Dec 10, 2019

Kubevirt VM overview CD-ROMs view is not aligned with design.

Ref: #3679 (comment)

Design:
End to End flow for CD ROMs in Virtual Machines Google Docs

After:
av2v cnv rhel7 mini · Details · OKD

Before:
av2v cnv rhel7 mini · Details · OKD(1)

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 10, 2019
@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Dec 10, 2019
@yaacov
Copy link
Member Author

yaacov commented Dec 10, 2019

@glekner @suomiy @matthewcarleton please review

@matthewcarleton this fix the unneeded css class from #3679 (comment).
@rawagner this fix the css naming issue from #3679 (review)

@yaacov yaacov changed the title move cd summary list closer to design Align cd summary list with design Dec 10, 2019
@yaacov
Copy link
Member Author

yaacov commented Dec 10, 2019

/test analyze

2 similar comments
@yaacov
Copy link
Member Author

yaacov commented Dec 10, 2019

/test analyze

@yaacov
Copy link
Member Author

yaacov commented Dec 10, 2019

/test analyze

@yaacov
Copy link
Member Author

yaacov commented Dec 10, 2019

/test e2e-gcp-console

matthewcarleton
matthewcarleton reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@matthewcarleton matthewcarleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only super picky thing I have is should we agree to kv- instead of kubevirt-? Follows the co- convention a bit more closely.

@yaacov
Copy link
Member Author

yaacov commented Dec 10, 2019

/test e2e-gcp-console

15 similar comments
@yaacov
Copy link
Member Author

yaacov commented Dec 10, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@atiratree
Copy link
Member

LGTM, the only super picky thing I have is should we agree to kv- instead of kubevirt-? Follows the co- convention a bit more closely.

we probably should include everyone in the conversation and appoint someone to do this convention conversion in a batch for all files

going forward with this one..

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

5 similar comments
@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@yaacov
Copy link
Member Author

yaacov commented Dec 11, 2019

/test e2e-gcp-console

@openshift-merge-robot openshift-merge-robot merged commit d1a6129 into openshift:master Dec 11, 2019
@spadgett spadgett added this to the v4.4 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewcarleton matthewcarleton matthewcarleton left review comments

@pcbailey pcbailey Awaiting requested review from pcbailey

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@atiratree atiratree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yaacov @atiratree @openshift-ci-robot @matthewcarleton @spadgett @openshift-merge-robot